Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore transitive dependencies via config flag #144

Closed
haraldreingruber-dedalus opened this issue Feb 18, 2021 · 4 comments
Closed

Ignore transitive dependencies via config flag #144

haraldreingruber-dedalus opened this issue Feb 18, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@haraldreingruber-dedalus
Copy link

haraldreingruber-dedalus commented Feb 18, 2021

For our about box we would just list the direct dependencies.
A config flag for ignoring transitive dependencies would be awesome!

Thanks a lot for sharing this really helpful tool 馃檹

@haraldreingruber-dedalus haraldreingruber-dedalus added the enhancement New feature or request label Feb 18, 2021
@Jake-Shadle
Copy link
Member

Seems reasonable!

@haraldreingruber
Copy link
Contributor

@Jake-Shadle we might look into working on a PR. I had a quick look into the repo, I guess such an option has to be passed in one way or another to the krates library, where the dependency graph is resolved?

Could you help me to find a potential starting point where the functionality would need to be implemented?
I had a look at the krates::builder module, but I did not yet spot the part resolving the transitive dependencies.

@Jake-Shadle
Copy link
Member

I think this would be the primary location to change. I think just changing the pid_stack to be a tuple of the package id as well as the depth of the dependency would mean you could just increment the depth when new packages are pushed onto the stack, and then if a depth limit is specified on the builder, just ignoring dependencies at that depth or lower.

@Jake-Shadle
Copy link
Member

Closed by #188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants