-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option in config/cli to exclude dev-dependencies for the workspace #322
Labels
enhancement
New feature or request
Comments
HippoBaro
added a commit
to HippoBaro/glommio
that referenced
this issue
Nov 26, 2021
The `chrono` crate has a security vulnerability and the ecosystem is moving away from it, so should be (also it annoys me that `cargo-check` doesn't pass any more because of this). See https://rustsec.org/advisories/RUSTSEC-2020-0159 for details. Cargo-check can't be configured to tolerate vulnerabilities in dev dependencies right now. It's a feature request, so maybe it'll come one day: EmbarkStudios/cargo-deny#322
HippoBaro
added a commit
to HippoBaro/glommio
that referenced
this issue
Nov 26, 2021
The `chrono` crate has a security vulnerability, and the ecosystem is moving away from it, so should be (also it annoys me that `cargo-check` doesn't pass anymore because of this). See https://rustsec.org/advisories/RUSTSEC-2020-0159 for details. Cargo-check can't be configured to tolerate vulnerabilities in dev dependencies right now. It's a feature request, so maybe it'll come one day: EmbarkStudios/cargo-deny#322
HippoBaro
added a commit
to HippoBaro/glommio
that referenced
this issue
Nov 26, 2021
The `chrono` crate has a security vulnerability, and the ecosystem is moving away from it, so should be (also it annoys me that `cargo-check` doesn't pass anymore because of this). See https://rustsec.org/advisories/RUSTSEC-2020-0159 for details. Cargo-check can't be configured to tolerate vulnerabilities in dev dependencies right now. It's a feature request, so maybe it'll come one day: EmbarkStudios/cargo-deny#322
HippoBaro
added a commit
to HippoBaro/glommio
that referenced
this issue
Nov 26, 2021
The `chrono` crate has a security vulnerability, and the ecosystem is moving away from it, so should we (also it annoys me that `cargo-check` doesn't pass anymore because of this). See https://rustsec.org/advisories/RUSTSEC-2020-0159 for details. Cargo-check can't be configured to tolerate vulnerabilities in dev dependencies right now. It's a feature request, so maybe it'll come one day: EmbarkStudios/cargo-deny#322
HippoBaro
added a commit
to DataDog/glommio
that referenced
this issue
Nov 26, 2021
The `chrono` crate has a security vulnerability, and the ecosystem is moving away from it, so should we (also it annoys me that `cargo-check` doesn't pass anymore because of this). See https://rustsec.org/advisories/RUSTSEC-2020-0159 for details. Cargo-check can't be configured to tolerate vulnerabilities in dev dependencies right now. It's a feature request, so maybe it'll come one day: EmbarkStudios/cargo-deny#322
Jake-Shadle
added a commit
that referenced
this issue
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now we disregard all dev-dependencies for non-workspace crates as they aren't even actually used in the workspace itself, however it's quite often that dev-dependencies of the workspace pull in eg duplicates or other issues that, while they do affect the workspace, are less of a concern since they are not actually a part of the final binary output of the workspace.
The text was updated successfully, but these errors were encountered: