Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow suppressing license was not encountered warning #352

Closed
soenkeliebau opened this issue Jul 14, 2021 · 2 comments
Closed

Allow suppressing license was not encountered warning #352

soenkeliebau opened this issue Jul 14, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@soenkeliebau
Copy link

Is your feature request related to a problem? Please describe.
We are using cargo-deny from CI in a number of internal repositories and have a list of licenses which we consider acceptable that should be applied to all repositories.

Since not all repositories have dependencies covering the entire list of allowed licenses we consistently get the below warning in some repositories:

warning[L006]: license was not encountered
   ┌─ /github/workspace/deny.toml:14:5
   │
14 │     "BSD-3-Clause",
   │     ^^^^^^^^^^^^^^ unmatched license allowance

Describe the solution you'd like
Ideally we'd like to be able to add a config setting to our deny.toml which says that we do not care about unmatched licenses from the whitelist, which would then suppress that warning.

Describe alternatives you've considered
We've considered two alternatives:

  1. Keep a separate list of licenses per repository and remove unused ones
  2. Live with the warning

We went with 2 for now, as option 1 creates unneeded overhead and the warning doesn't fail the CI job.

@soenkeliebau soenkeliebau added the enhancement New feature or request label Jul 14, 2021
thomcc added a commit to thomcc/cargo-deny that referenced this issue Sep 30, 2021
thomcc added a commit to thomcc/cargo-deny that referenced this issue Sep 30, 2021
@mergify mergify bot closed this as completed in 128ae2c Oct 1, 2021
@lfrancke
Copy link

lfrancke commented Oct 1, 2021

Thank you @thomcc! This is useful.

@soenkeliebau
Copy link
Author

I indeed, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants