Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for parallel fetching #537

Closed
Jake-Shadle opened this issue Jul 29, 2023 · 0 comments · Fixed by #566
Closed

Add tests for parallel fetching #537

Jake-Shadle opened this issue Jul 29, 2023 · 0 comments · Fixed by #566
Labels
enhancement New feature or request

Comments

@Jake-Shadle
Copy link
Member

I resolved #479, but I only did basic manual checking before and after to validate the fix, but really both parallel db fetching as well as parallel cargo (git) index updating should be made into integration tests to avoid regressions as well as just give higher confidence.
@Jake-Shadle Jake-Shadle added the enhancement New feature or request label Jul 29, 2023
@EmbarkStudios EmbarkStudios deleted a comment from hrisheekesh0515 Sep 29, 2023
@Jake-Shadle Jake-Shadle mentioned this issue Sep 29, 2023
Merged
Jake-Shadle added a commit that referenced this issue Sep 29, 2023
@Jake-Shadle
Update tame-index/gix (#566)
7965a5e 
This updates tame-index, which includes
EmbarkStudios/tame-index#33, which allows
cargo-deny to use OS file locking for safer interactions with cargo, as
well as improved safety and robustness for read/fetching advisory
databases.

This doesn't add new tests as I'm _pretty_ confident the OS file locking
code works correctly, which means #537 is basically covered since it's
more robust now.

Resolves: #537
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update tame-index/gix EmbarkStudios/cargo-deny
1 participant
@Jake-Shadle