Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Failure to query SSH registry for yanked crates #548

Closed
fsavy-tehtris opened this issue Aug 23, 2023 · 0 comments · Fixed by #549
Closed

Bug: Failure to query SSH registry for yanked crates #548

fsavy-tehtris opened this issue Aug 23, 2023 · 0 comments · Fixed by #549
Labels
bug Something isn't working

Comments

@fsavy-tehtris
Copy link

fsavy-tehtris commented Aug 23, 2023

Describe the bug

Running cargo deny check advisories on a project that uses a git SSH registry fails when checking for the yanked status.

warning[index-failure]: unable to check for yanked crates
  ┌─ /tmp/deny-ssh/Cargo.lock:3:1
  │
3 │ quote 1.0.33 registry+ssh://git@github.com/rust-lang/crates.io-index.git
  │ ------------------------------------------------------------------------ crate whose registry we failed to query
  │
  = unable to find crate in cache
  = quote v1.0.33
    └── deny-ssh v0.1.0

To reproduce

Add a custom registry

# .cargo/config.toml
[registries.test]
index = "ssh://git@github.com/rust-lang/crates.io-index.git"

Then add a dependency:

cargo add quote --registry test

Run cargo deny check and see many warnings like the one above.

cargo-deny version

0.14.1

What OS were you running cargo-deny on?

Linux

Additional context

I've tried using git-fetch-with-cli = true, the outcome is the same.

@fsavy-tehtris fsavy-tehtris added the bug Something isn't working label Aug 23, 2023
Jake-Shadle added a commit to EmbarkStudios/tame-index that referenced this issue Aug 23, 2023
This is the fix for
EmbarkStudios/cargo-deny#548 as the hash was
correct since it takes the entirety of the user provided url into
account, but it wasn't stripping off the user portion of the url causing
it to look at the wrong local directory.
Jake-Shadle added a commit that referenced this issue Sep 2, 2023
- Fix committer name
- Update krates/tame-index/gix
- Checkpoint
- Update dependencies

Resolves: #43 
Resolves: #548 
Resolves: #552
Resolves: #553 (I guess? It adds a feature toggle for using the OS
certificate store)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant