Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print diagnostic for missing clarification files #249

Merged
merged 2 commits into from
Oct 13, 2020
Merged

Print diagnostic for missing clarification files #249

merged 2 commits into from
Oct 13, 2020

Conversation

khodzha
Copy link
Contributor

@khodzha khodzha commented Aug 18, 2020 •
edited by Jake-Shadle
Loading

Resolves: #190

@khodzha
Copy link
Contributor Author

khodzha commented Aug 18, 2020

this should address #190
it looks like this running in this repo
image

@khodzha khodzha force-pushed the license_file branch 2 times, most recently from 11c48c9 to 8aa388c Compare August 18, 2020 20:29
@Jake-Shadle Jake-Shadle changed the title print notification when a file from license-files list doesnt exist Print diagnostic for missing clarification files Oct 13, 2020
@Jake-Shadle Jake-Shadle self-requested a review October 13, 2020 11:42
Jake-Shadle
Jake-Shadle approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@Jake-Shadle Jake-Shadle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the PR, I'm really sorry how long it took me to get around to merging it!

@mergify mergify bot merged commit 4e068f7 into EmbarkStudios:main Oct 13, 2020
@khodzha khodzha deleted the license_file branch October 13, 2020 11:46
@khodzha
Copy link
Contributor Author

khodzha commented Oct 13, 2020

its ok 👍

@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jake-Shadle Jake-Shadle Jake-Shadle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarification with incorrect path doesn't error
2 participants
@khodzha @Jake-Shadle