Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize source URLs #274

Merged
merged 2 commits into from
Oct 3, 2020

Conversation

senden9
Copy link
Contributor

@senden9 senden9 commented Oct 3, 2020

Fixes #115.
As said in the linked issue we should discus if this is enough normalization. Also I am not sure if it is a good idea to change values in the validation step.

Besides do the normalization I also adapted the test file so that the new feature will be tested. This test fails with the old version version of cargo-deny and passes with the changes in this PR.

@senden9
Copy link
Contributor Author

senden9 commented Oct 3, 2020

CI cached a bug it seams. texture-synthesis is OK with the current release of cargo-deny but not with my modified version. I will take a look.

➜  texture-synthesis git:(main) ~/git/cargo-deny/target/debug/cargo-deny check
error: detected 'git' source not specifically allowed
   ┌─ /home/stefano/git/texture-synthesis/Cargo.lock:29:16
   │
29 │ img_hash 2.1.0 git+https://github.com/EmbarkStudios/img_hash.git?rev=c40da78#c40da78946840c810543e6ec53967afb7adafd74
   │                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ source
   │
   = img_hash v2.1.0
     └── (dev) texture-synthesis v0.8.0
         └── texture-synthesis-cli v0.8.0

warning: allowed source was not encountered
   ┌─ /home/stefano/git/texture-synthesis/deny.toml:45:5
   │
45 │     "https://github.com/EmbarkStudios/img_hash.git",
   │     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no crate source matched these criteria

advisories ok, bans ok, licenses ok, sources FAILED

@Jake-Shadle
Copy link
Member

Don't worry about, that repo is just outdated.

@Jake-Shadle Jake-Shadle self-requested a review October 3, 2020 09:29
Copy link
Member

@Jake-Shadle Jake-Shadle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I've been bad about merging PRs so I'll just merge this now, can improve it later. 🙂

@mergify mergify bot merged commit 3b44a46 into EmbarkStudios:main Oct 3, 2020
@senden9 senden9 deleted the feature/normalize_source_urls branch October 3, 2020 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Normalize source urls
2 participants