Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort crates by version when synthesizing the virtual Cargo.lock file #414

Merged
merged 1 commit into from
Apr 10, 2022

Conversation

Veykril
Copy link
Contributor

@Veykril Veykril commented Apr 9, 2022

Fixes #384

@Veykril Veykril changed the title Sort listed duplicates by version for deterministic reporting Sort crates by version when synthesizing the virtual Cargo.lock file Apr 9, 2022
@Veykril
Copy link
Contributor Author

Veykril commented Apr 10, 2022

Looks like there are some new lints being hit? Should I fix these in this PR?

@Jake-Shadle
Copy link
Member

I've fixed them in #415 just needs a rebase.

@Jake-Shadle Jake-Shadle merged commit 9b69c96 into EmbarkStudios:main Apr 10, 2022
@Veykril Veykril deleted the dupe-sort branch April 10, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deterministically order versions in duplicate reports
2 participants