Add default lint level for default features #461
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the configuration of features, as, in #434, the configuration followed exactly what was proposed in #226, but on reflection that configuration would be super confusing, so now
bans.features
is its own top-level option.This PR also adds two new configuration options,
bans.workspace-default-features
andbans.external-default-features
which allows configuration of a default lint option for either workspace or external (non-workspace) crates. This default can then be overriden specifically for a crate, eg.Would allow default features on
a-workspace-crate
, but deny them on any other workspace crate.Also adds more testing of feature banning, to where I'm fairly confident this resolves #226.
Resolves: #206
Resolves: #226
Closes: #347