Fix discord app registration on Windows #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
Discord app registration was broken on at Win 11 (unclear if it worked on previous versions) due to the verbatim prefix (
\\?\) that was added to the exe path. Apparently this isn't supported when the path with the prefix is saved in the registry as the shell open command. It would simply fail to open the registered app.I also compared to some other games I had registered and tweaked the
DefaultIconlocation (+ path to strip the prefix) as well as some other register key values to more closely mimic how the "official" registration is done. Code for the official version can be found here.Tested on Win 11 and could confirm the app launched correctly