Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cfg issues #83

Merged
merged 5 commits into from
Apr 11, 2024
Merged

Fix cfg issues #83

merged 5 commits into from
Apr 11, 2024

Conversation

Jake-Shadle
Copy link
Member

  • Fix dependency pairing
  • Fix additional issue

This fixes 2 issues:

  1. A dependencies cfg was not being taken into account when pairing the resolved node to its krate dependency, which could cause features only used by a specific cfg to not be included. This was bad, but now fixed.
  2. Noticed an issue when adding a test case for the above, which is that cfg(any()), which can never evaluate to true, would cause the edge to be included in the graph when not filtering by target.

Resolves: #82

We we were ignoring the cfg of the dependency when locating the krate dependency for a resolved node
Noticed this when adding the new test case, if not filtering targets then expressions that could never evaluate to true were causing graph inclusion
@Jake-Shadle Jake-Shadle merged commit 0ffe190 into main Apr 11, 2024
6 checks passed
@Jake-Shadle Jake-Shadle deleted the fix-cfg branch April 11, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: overriding feature make banned crate pass the check
1 participant