Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for enum attributes #23

Merged
merged 2 commits into from Apr 25, 2024
Merged

Add support for enum attributes #23

merged 2 commits into from Apr 25, 2024

Conversation

rasviitanen
Copy link
Member

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

Adds support for enum attributes.

https://docs.rs/prost-build/latest/prost_build/struct.Config.html#method.enum_attribute

bwestlin
bwestlin approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@bwestlin bwestlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LG Could you add an entry in the changelog as well under unreleased?

@rasviitanen rasviitanen merged commit 3176066 into main Apr 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwestlin bwestlin bwestlin approved these changes

@MarcusGrass MarcusGrass Awaiting requested review from MarcusGrass MarcusGrass is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rasviitanen @bwestlin