Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging child scopes gives skewed timeline view #106

Open
repi opened this issue Oct 25, 2022 · 0 comments
Open

Merging child scopes gives skewed timeline view #106

repi opened this issue Oct 25, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@repi
Copy link
Contributor

repi commented Oct 25, 2022

When one uses the default "Merge children with same ID" it merges a child scopes regardless of the time offset they are on, which gives a skewed view over how the execution worked.

For example this:

image

Becomes:

image

Which can be confusing an unexpected because on the latter (which is default) it looks like there is single large block that is missing smaller profiler scopes on it.

Expected behavior

I did expect it to only merge child scopes that were next to each other on the time line, maybe not exactly (due to timing precision) but not fundamentally change the timing view.

Let's discuss how to proceed with this or if we simply should disable "Merge children with same ID" by default and describe this gotcha, as believe we've internally run into this quite a few times causing confusion as the profiler with it is not showing the correct time perspective on things

@repi repi added the bug Something isn't working label Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant