Change chrono dep to time #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
approved these changes
Dec 19, 2022
| @@ -104,6 +104,7 @@ use std::{ | |||
| fmt::Write as _, | |||
| sync::{Arc, Mutex}, | |||
| }; | |||
| use time::{macros::format_description, OffsetDateTime}; | |||
There was a problem hiding this comment.
You can move the use statement to unside fn format_time
- less pollution of file namespace
- when reading
format_timeit's easier to find where the names come from
|
OH, bot merged it. Will do the changes! |
|
the bot merged a red PR? 🤦 |
emilk
reviewed
Dec 19, 2022
| @@ -21,7 +21,7 @@ include = [ | |||
| # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html | |||
|
|
|||
| [dependencies] | |||
| chrono = "0.4" | |||
| time = { version = "0.3.17", default-features = false, features = [ "parsing" ] } | |||
There was a problem hiding this comment.
you are not really parsing time though?
There was a problem hiding this comment.
Fixed, it, changed to formatting, and also had to enable the macro feature flag. I tested my changes from root repo, turns out, when I compiled puffin egui only, it had compile errors. This was because other dependencies included the macro feature flag which puffin egui does not depend on. I directly pushed to main to fix those issues.
Also released a new patch version for your flamegraph and this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason: