Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update egui to 0.19 #93

Merged
merged 5 commits into from
Oct 1, 2022
Merged

Update egui to 0.19 #93

merged 5 commits into from
Oct 1, 2022

Conversation

sidit77
Copy link
Contributor

@sidit77 sidit77 commented Sep 3, 2022

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

I've updated egui to 0.19 to make puffin_egui compatible with that version.

Related Issues

N/A

puffin_egui/Cargo.toml Outdated Show resolved Hide resolved
@repi repi changed the title updated egui to 0.19 Update egui to 0.19 Sep 6, 2022
@TimonPost TimonPost removed the request for review from VZout October 1, 2022 15:10
@TimonPost
Copy link
Member

Thanks! Can be merged once the linting errors are resolved.

@sidit77
Copy link
Contributor Author

sidit77 commented Oct 1, 2022

Ah, I think the problem is that I only updated puffin_egui and not the other packages. I'll try to update them as soon as possible.

@sidit77
Copy link
Contributor Author

sidit77 commented Oct 1, 2022

Sorry for making this way harder than it should be. I keep forgetting one of the lints when running them locally.

@emilk
Copy link
Collaborator

emilk commented Oct 1, 2022

No worries @sidit77 - have you tried check.sh?

@sidit77
Copy link
Contributor Author

sidit77 commented Oct 1, 2022

Oh, that's actually pretty useful. I'm running it right now to make sure that the last update will really really really be the last.

@TimonPost
Copy link
Member

Thank you very much!

@TimonPost TimonPost merged commit 87ba0ed into EmbarkStudios:main Oct 1, 2022
@emilk
Copy link
Collaborator

emilk commented Oct 2, 2022

A new egui-macroquad 0.12 with egui 0.19 support has beend has been released: optozorax/egui-macroquad@6973d47

@sidit77
Copy link
Contributor Author

sidit77 commented Oct 2, 2022

I already reenabled the demo: ac8745d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants