Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hello world tests for simple/glsl mem model, and various spir-v versions #175

Closed
khyperia opened this issue Oct 29, 2020 · 2 comments
Closed

Add hello world tests for simple/glsl mem model, and various spir-v versions #175

khyperia opened this issue Oct 29, 2020 · 2 comments
Assignees
@khyperia
Labels
a: test Issues around testing rust-gpu. c: rustc_codegen_spirv Issues specific to the rustc_codegen_spirv crate. t: good first issue Good for newcomers t: help wanted Extra attention is needed

Comments

@khyperia
Copy link
Contributor

tl;dr test #165 and #168

make sure NO_DCE is enabled for the tests once that's fixed for "extra" test coverage
@khyperia khyperia added c: rustc_codegen_spirv Issues specific to the rustc_codegen_spirv crate. a: test Issues around testing rust-gpu. labels Oct 29, 2020
@khyperia khyperia self-assigned this Oct 29, 2020
@khyperia khyperia mentioned this issue Oct 29, 2020
Closed
@khyperia
Copy link
Contributor Author

khyperia commented Apr 1, 2021

This might be more feasible and easy now that compiletests can easily specify flags, and the target triple specifies the spir-v version and memory model.

@XAMPPRocky XAMPPRocky added t: good first issue Good for newcomers t: help wanted Extra attention is needed labels Apr 1, 2021
@khyperia
Copy link
Contributor Author

Now that I think about this more, this is probably not worth the CI time - it's definitely not insignificant, and not really much benefit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khyperia khyperia

Labels
a: test Issues around testing rust-gpu. c: rustc_codegen_spirv Issues specific to the rustc_codegen_spirv crate. t: good first issue Good for newcomers t: help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@khyperia @XAMPPRocky