Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert panics to compiler errors #43

Closed
khyperia opened this issue Oct 1, 2020 · 1 comment · Fixed by #66
Closed

Convert panics to compiler errors #43

khyperia opened this issue Oct 1, 2020 · 1 comment · Fixed by #66

Comments

@khyperia
Copy link
Contributor

khyperia commented Oct 1, 2020

There's a whole heck of a lot of panics, unwraps, and what-have-yous in rustc_codegen_spirv right now. Nearly all of them should probably be compiler errors instead.

Note this may require some rustc PRs, since right now, backends don't have access to span information. @eddyb may have some ideas around how to get span information, e.g. a bx.set_span method.
This was referenced Oct 1, 2020
Closed
Closed
Closed
@khyperia
Copy link
Contributor Author

khyperia commented Oct 6, 2020 •
edited
Loading

bx.set_span: rust-lang/rust#77614

edit: has been merged, should be available in the next nightly - so, should be able to start on the conversion work.

This was referenced Oct 13, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert panics to compiler errors EmbarkStudios/rust-gpu
1 participant
@khyperia