Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom endpoints #21

Closed
kennytm opened this issue May 3, 2020 · 1 comment
Closed

Support custom endpoints #21

kennytm opened this issue May 3, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@kennytm
Copy link

kennytm commented May 3, 2020

Is your feature request related to a problem? Please describe.

tame-gcs currently hardcodes the request URLs

"https://www.googleapis.com/upload/storage/v1/b/{}/o?uploadType=multipart",

"https://www.googleapis.com/storage/v1/b/{}/o/{}?alt=json",

If we want to use change the endpoints to use other GCS-compatible services e.g. fake-gcs-server, we will need to manually replace the URLs in the generated http::Request, which is awkward.

Note that the official GCS libraries in all other languages support providing custom endpoints:

Describe the solution you'd like

Have an API specifying which endpoint to use.

Describe alternatives you've considered

Additional context

@Jake-Shadle
Copy link
Member

Resolved by #59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants