Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local feature is not additive #16

Closed
epage opened this issue Aug 22, 2023 · 1 comment · Fixed by #18
Closed

local feature is not additive #16

epage opened this issue Aug 22, 2023 · 1 comment · Fixed by #18
Labels
bug Something isn't working

Comments

@epage
Copy link

epage commented Aug 22, 2023

Describe the bug
If one package is using tame-index and another package activates feature = "local", then the build will break

Expected behavior
Build should not break; features should be additive

Additional context
Potential solutions

  • Make ComboIndexCache non_exhaustive
  • Have the Local variant but ensure LocalRegistry can never be constructed
@epage epage added the bug Something isn't working label Aug 22, 2023
@epage
Copy link
Author

epage commented Aug 22, 2023

It'd also be useful to use #![cfg_attr(docsrs, feature(doc_auto_cfg))] like I do with clap. While reviewing crate-ci/cargo-release#693, I was scratching my head for a bit as to why I see LocalRegistry in the docs but it wasn't being matched in the PR.

Jake-Shadle added a commit that referenced this issue Aug 23, 2023
This changes the `SparseIndex` API slightly to allow for zero disk I/O
when making requests to the remote HTTP index.

Resolves: #16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant