Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Builder public #10

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Make Builder public #10

merged 1 commit into from
Apr 12, 2023

Conversation

davidpdrsn
Copy link
Member

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

Makes the Builder type public. It wasn't previously so the retur value from
tracing_logfmt::builder() couldn't be named and you couldn't see the docs for
it.

@davidpdrsn davidpdrsn requested a review from fredr as a code owner April 12, 2023 08:33
fredr
fredr approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@fredr fredr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@davidpdrsn davidpdrsn merged commit ff52c97 into main Apr 12, 2023
@davidpdrsn davidpdrsn deleted the david/public-builder branch April 12, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredr fredr fredr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidpdrsn @fredr