Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to enable coloured keys and logger level. #11

Merged
merged 4 commits into from
Aug 22, 2023

Conversation

euamcg
Copy link
Contributor

@euamcg euamcg commented Aug 16, 2023

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

Adds the ability to enable coloured keys and the level of the logger. If you have any suggestions to changes I can make or would like to fix please let me know.

@euamcg euamcg requested a review from fredr as a code owner August 16, 2023 14:26
src/formatter.rs Outdated Show resolved Hide resolved
src/formatter.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@fredr fredr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

I added some minor changes/improvement as comments, re-request a review when they are fixed, and I'll merge it 🚀

@euamcg
Copy link
Contributor Author

euamcg commented Aug 17, 2023

@fredr Pushed the changes, take a look when you can, cheers.

@euamcg euamcg requested a review from fredr August 17, 2023 13:37
Copy link
Contributor

@fredr fredr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Will cut a new release soon

@fredr
Copy link
Contributor

fredr commented Aug 18, 2023

Ah, didn't realize that the CI hadn't run yet, sorry about that. If you could fix the clippy lint, I can help out with the deny thing

@euamcg euamcg requested a review from fredr August 18, 2023 15:45
@euamcg
Copy link
Contributor Author

euamcg commented Aug 18, 2023

Ah, didn't realize that the CI hadn't run yet, sorry about that. If you could fix the clippy lint, I can help out with the deny thing

Fixed the clipply warnings, take a look when you can. Thanks!

@fredr fredr merged commit 2505104 into EmbarkStudios:main Aug 22, 2023
6 checks passed
@fredr
Copy link
Contributor

fredr commented Aug 22, 2023

released in 0.3.3 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants