Fix corrupt clientList bug in TransportArbitrator #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If m_clientList is null and m_clientFreeList has more than one node, m_clientList->m_next will point back to m_clientFreeList. This results in an error in the destructor. Always setting 'info->m_next = m_clientList' fixes the issue
|
Hello @ramlco , thank for this PR with the bugfix. I am ok with these changes but could you please format the code correctly (see https://github.com/EmbeddedRPC/erpc/wiki/Contributing) - there are tabs in changed lines. And, also could you please rebase to the develop head (it seems failing greetings action blocks consequent Travis build check). Thank you. |
Hadatko
approved these changes
Jan 21, 2022
Hadatko
approved these changes
Jan 28, 2022
There was a problem hiding this comment.
I fixed indention. So i think it is ready for merge. @MichalPrincNXP
MichalPrincNXP
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If m_clientList is null and m_clientFreeList has more than one node, m_clientList->m_next will point back to m_clientFreeList. This results in an error in the destructor. Always setting 'info->m_next = m_clientList' fixes the issue