Fixed codec nullptr dereferencing.

[Hadatko]

Signed-off-by: Cervenka Dusan cervenka@acrios.com

Pull request

Choose Correct

• bug
• feature

Describe the pull request

#263

To Reproduce

Expected behavior

Screenshots

Desktop (please complete the following information):

• OS:
• eRPC Version:

Steps you didn't forgot to do

• I checked if other PR isn't solving this issue.
• I read Contribution details and did appropriate actions.
• PR code is tested.
• PR code is formatted.

Additional context

[Hadatko]

This PR should be ready to merge.

[smithBraun]

I suggest (maybe in addition?) to call the dispose function just if it not null

    // Get a new request.
    RequestContext request = g_client->createRequest(false);

    // Encode the request.
    Codec * codec = request.getCodec();

    if (codec == NULL)
    {
        err = kErpcStatus_MemoryError;
    }
    else
    {
        ...
    // Dispose of the request.
    g_client->releaseRequest(request);
    }

[Hadatko]

I suggest (maybe in addition?) to call the dispose function just if it not null

    // Get a new request.
    RequestContext request = g_client->createRequest(false);

    // Encode the request.
    Codec * codec = request.getCodec();

    if (codec == NULL)
    {
        err = kErpcStatus_MemoryError;
    }
    else
    {
        ...
    // Dispose of the request.
    g_client->releaseRequest(request);
    }

I was thinking about this implementation too. It is correct, but it may be tricky if there will be change in RequestContext. Logically i don't like that createRequest is called in different scope than release request. As this are pair functions.

[smithBraun]

OK, agree.
Another thing that is bothering me her is that we know that g_client->createRequest(false); failed just with looking on the codec, isn't there is some status we can return and check it for failures?

[Hadatko]

OK, agree. Another thing that is bothering me her is that we know that g_client->createRequest(false); failed just with looking on the codec, isn't there is some status we can return and check it for failures?

I understand what you want to achieve. I think it is not necessary right now. But it can be usefull in future if another allocation may failed during RequestContext creation...

[MichalPrincNXP]

Thank you!