Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed flags for macOS build #301

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Changed flags for macOS build #301

merged 1 commit into from
Aug 9, 2022

Conversation

hp-peti
Copy link
Contributor

@hp-peti hp-peti commented Jul 25, 2022 •
edited
Loading

Pull request

Choose Correct

  • bug
  • feature

Describe the pull request

Change paths for MACOS homebrew build on Apple Silicon

To Reproduce

make

Expected behavior

build completes

Screenshots

Desktop (please complete the following information):

  • OS: macOS Monterey Apple Silicon with Homebrew 3.5.6 (aarch64)
  • eRPC Version:

Steps you didn't forgot to do

  • I checked if other PR isn't solving this issue.
  • I read Contribution details and did appropriate actions.
  • PR code is tested.
  • PR code is formatted.

Additional context

@Hadatko
Copy link
Member

Hadatko commented Jul 25, 2022

We still don't have Mac builds as i am not able to enable it :/ I don't know how to doeble check proposed solution

@MichalPrincNXP
Copy link
Member

We still don't have Mac builds as i am not able to enable it :/ I don't know how to doeble check proposed solution

Hi Dusan, I have re-enabled Travis and triggered manually a build on mainline, see https://app.travis-ci.com/github/EmbeddedRPC/erpc/builds/253676150 .... there is some problem in MAC gcc build, do you know how to address that?

To trigger a new Travis build on this PR, I will try to close and reopen this PR.

@Hadatko
Copy link
Member

Hadatko commented Jul 27, 2022 •
edited
Loading

Looks like build failed :
image
We will like want get rid of that compile macro for mac

@MichalPrincNXP
Copy link
Member

Hi @hp-peti
there is the following Travis MAC build issue:
image
(whole log available here: https://app.travis-ci.com/github/EmbeddedRPC/erpc/jobs/577893764)

Could you please help to identify that is wrong?

@Hadatko Hadatko assigned Hadatko and hp-peti and unassigned Hadatko Jul 27, 2022
@hp-peti
Copy link
Contributor Author

hp-peti commented Jul 27, 2022

Hi @hp-peti there is the following Travis MAC build issue: image (whole log available here: https://app.travis-ci.com/github/EmbeddedRPC/erpc/jobs/577893764)

Could you please help to identify that is wrong?

Please observe modified PR where paths are no longer hardcoded.

@hp-peti hp-peti closed this Jul 27, 2022
@hp-peti hp-peti reopened this Jul 27, 2022
@hp-peti
Changed flags for macOS build
b82d0ff 
- assuming homebrew
- query boost, flex and bison prefixes directly from brew
- tested locally on macOS Monterey arm64 using Homebrew 3.5.6
@MichalPrincNXP
Copy link
Member

Thank you, @hp-peti , look better now. Could you please made another modification of flags.mk? Please made following modifications at line 41:
ifneq "$(is_darwin)" "1"
ifeq "$(CXX)" "g++"
CXXFLAGS += -Wno-free-nonheap-object
endif
endif

This should solve the MAC/gcc build issue as confirmed by https://app.travis-ci.com/github/EmbeddedRPC/erpc/builds/253688589

I would like to have it in one PR and under one Travis build. Please do that in a new commit, thus a new Travis build will be triggered. Thank you

@MichalPrincNXP MichalPrincNXP merged commit 1b30973 into EmbeddedRPC:develop Aug 9, 2022
@MichalPrincNXP
Copy link
Member

Thank you, @hp-peti

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichalPrincNXP MichalPrincNXP MichalPrincNXP approved these changes

Assignees

@hp-peti hp-peti

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hp-peti @Hadatko @MichalPrincNXP