-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Many minor code improvements. #323
Many minor code improvements. #323
Conversation
@MichalPrincNXP i think this one can be merged. But it needs run as many tests/apps as we have. |
I have started testing locally, erpcgen builds seems to be ok, there are several build issues, see my two comments. Could you please rebase to the develop branch head? |
Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
23ded4a
to
f5b586a
Compare
I made changes based on your notes. Good eyes. Thank you ;) |
Thank you for the update and rebase, I will continue with on-board testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All build and on-board tests passed.
Thank you |
Signed-off-by: Cervenka Dusan cervenka@acrios.com
Pull request
Choose Correct
Describe the pull request
Minor changes to type definitions and casts. This can lower memory/cpu usage a bit for generating shim code.
To Reproduce
Expected behavior
tests pass
Screenshots
Desktop (please complete the following information):
Steps you didn't forgot to do
Additional context