-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated erpc_python/setup.py #38
Conversation
* fix premature import of package, causing failure when attempting installation of Python library in a clean environment.
Hi, thank you for your contribution. Could you change destination branch to develop. |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes are fine. I would put ERPC_VERSION = None before opening file (fixing editor warning highlight).
Apply review suggestion: initialize ERPC_VERSION to None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much that you are still active, this should be merge soon if @MichalPrincNXP will agree.
Thank you for the effort and the patience! |
Description
Updated
erpc_python/setup.py
. Remove import of theerpc_version
submodule, causing execution of the package initialization script, pulling another submodules and in consequence causing failure of package installation in a clean Python environment. Instead of usingimport
feature, open theerpc_version.py
file directly in execute it, causingERPC_VERSION
constant to be available directly in the namespace whensetup
function is being executed.Related Issue
Resolves #37