This repository has been archived by the owner on Jan 16, 2024. It is now read-only.
Enable all swiper options and replace observers #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Test error seems to be related to ember-cli/ember-try#148. Only failing for |
|
A first quick look seemed good (: Thanks for your effort! I'll check deeper in the comming days. |
|
@Suven any thoughts yet? |
|
i would benefit from this PR going in. |
0xadada
approved these changes
Nov 2, 2017
|
@Suven seems like we had enough consensus so I've merged this PR and published a new release. Please run |
This was referenced Nov 11, 2017
Closed
|
Thank you so much for this. Can't wait to try it. 👍 :) |
|
@Suven can you |
|
@Suven |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes all component attributes as configuration options to Swiper and replaces usage of observers with component lifecycle hooks.
This PR is an exclusive alternative for #32.
This PR closes issues: #72, #53, #51, #10.
Looking for feedback and review from the community before getting this merged.