Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearranged so await component resolves correctly #6

Merged
merged 1 commit into from Jun 13, 2020

Conversation

imagolive
Copy link
Contributor

Await was not resolving. Had a go at rearranging it so it resolves correctly.

Not sure if this is the right way. Never modified an add-on like this.

@Exelord
Copy link
Member

Exelord commented Jun 12, 2020

Could to describe the issue a bit more? 🤔
What ember version are you using? :)

@knownasilya
Copy link
Contributor

knownasilya commented Jun 12, 2020

Addons cannot have folders (pods style) when reexporting components in app folder.

@Exelord
Copy link
Member

Exelord commented Jun 13, 2020

Hmm... Im wondering why dummy app works then. 🤔

@knownasilya
Copy link
Contributor

Yeah, it's inconsistent, hence not recommend. Bug somewhere in resolver.

@Exelord
Copy link
Member

Exelord commented Jun 13, 2020

I tested that in a new app and everything works as expected. I need more details what is exactly not working, and in which ember's version

@knownasilya
Copy link
Contributor

It might be if the app is using pods? Mine is. Latest version.

@Exelord
Copy link
Member

Exelord commented Jun 13, 2020

Hmm... I work on app which use pods, and addons with the same export pattern. That works too. The issue needs to be somewhere else. 🤔

@knownasilya
Copy link
Contributor

Are you using podModulePrefix? Mine is set

@Exelord
Copy link
Member

Exelord commented Jun 13, 2020

Confirmed podModulePrefix is the issue. Pods without this option work fine as well as classic structure. I think that issue should be reported in ember-cli repo.

@Exelord
Copy link
Member

Exelord commented Jun 13, 2020

For now, lets use this one as hotfix for the issue

@Exelord Exelord merged commit cc280bf into EmberExperts:master Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants