-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: api mocking wip #1530
test: api mocking wip #1530
Conversation
Deploying with
|
Latest commit: |
bb58d24
|
Status: | ✅ Deploy successful! |
Preview URL: | https://27aa751d.emeris-app.pages.dev |
e2e/assets-page.spec.ts
Outdated
page.route('https://api.emeris.com/**/*', mockHandler); | ||
page.on('domcontentloaded', () => { | ||
page.evaluate('window.Cypress=true; window.chrome=true; window.keplr={}'); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we import this to centralize in one file as it seems repeated in all test files?
1 similar comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel this is a regression because we are using the mocks by default...
Can't we make it an option? So that we can only use the mocks when backend stability is causing our tests to fail?
That we can ourselves choose
"use the real data" or "use the mocks"?
I'm not gonna enable it just yet....it's enabled to test the ci. Will only add it on specific tests going forward |
won't be merged with "page.route('https://api.emeris.com/**/*', mockHandler);"
Description
Please include a summary of the change and which issue(s) is/are fixed.
Fixes: # (issue)
Feature flags
Please mention the feature flags to be used for testing.
Testing
Please provide the steps for testing this PR.
Additional Details (Optional)
For additional details.
Reviews (Optional)
Please mention developer(s) who should definitely review this change. Use this when your code would be used by a larger component or modifies core functionality or modifies an existing component being used in a lot of places etc.
Screenshots (Optional)
Please attach screenshots if required.