Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Cache download_key_ids #67

Open
xcorvis opened this issue Jan 29, 2023 · 1 comment
Open

Feature Request: Cache download_key_ids #67

xcorvis opened this issue Jan 29, 2023 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@xcorvis
Copy link

xcorvis commented Jan 29, 2023

When downloading purchased games individually it's necessary to first get the download_key_id. With large libraries this can be many pages, which must be repeated for each individual purchased download. One fix for this would be to download and cache the download_key_ids if it's missing, and re-use the cache when it's available.

See #63 for background.

I have hundreds of purchased games due to a few large bundles, but I don't want everything, and the itch.io official app is so bad at multiple file downloads it's unusable. Ultimately I'd like to be able to create a list of games I want to keep updated and run something like this once in a while:

itch-download -k $key --update-purchases --cache .itchiodl-cache
for $game-url in list-of-games; do
  itch-download -k $key --cache .itchiodl-cache --download-game $game-url
done
@Emersont1 Emersont1 added this to the 3.0 Release milestone Jan 29, 2023
@Emersont1 Emersont1 added the enhancement New feature or request label Jan 29, 2023
@Emersont1
Copy link
Owner

  • If the aim is to keep selected games up to date (provided the required id doesn't change over time), then we may be able to read it from the JSON files written alongside the game.
  • Caching the download_key_ids is probably a good solution, but it will stop after it finds it, so it can't guarantee being able to find it if we directly cache the output so would need a separate cache command as suggested

N64Core pushed a commit to N64Core/itchio that referenced this issue Mar 21, 2023
…ained free demo content

Added key pair caching code to support faster checking of owned single downloads

load_game was condensed as the ownership check no longer occurs inside it

Key pair caching can also be used for issue Emersont1#67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants