New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent duplicate slug values #159
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansentjeu
requested changes
Mar 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jansentjeu
approved these changes
Mar 1, 2024
ah-net
added a commit
that referenced
this pull request
Mar 15, 2024
* Prevent duplicate slug values (#159) Prevent duplicate slug values * Fix notice missing variables (#157) * Bump version * chore: Added semantic release (#158) * chore: Added semantic release * chore: Added develop branch to semantic release * chore: Set beta branch as prerelease branch * chore: Only trigger release workflow for master and beta branch (#160) * chore: Updated README for semantic release --------- Co-authored-by: Tjeu Jansen <161043478+jansentjeu@users.noreply.github.com> Co-authored-by: tjeujansen <tjansen@emico.nl>
ah-net
added a commit
that referenced
this pull request
Apr 10, 2024
* chore: Added semantic release (#158) * chore: Added semantic release * chore: Added develop branch to semantic release * chore: Set beta branch as prerelease branch * chore: Only trigger release workflow for master and beta branch (#160) * chore: Updated README for semantic release * Merge master back to beta branch (#165) * Prevent duplicate slug values (#159) Prevent duplicate slug values * Fix notice missing variables (#157) * Bump version * chore: Added semantic release (#158) * chore: Added semantic release * chore: Added develop branch to semantic release * chore: Set beta branch as prerelease branch * chore: Only trigger release workflow for master and beta branch (#160) * chore: Updated README for semantic release --------- Co-authored-by: Tjeu Jansen <161043478+jansentjeu@users.noreply.github.com> Co-authored-by: tjeujansen <tjansen@emico.nl> * chore: Added Youwe Testing Suite * chore: Added Magento secrets in testing suite action * chore: Fixed phpmd linter * chore: Run grumphp directly with PHP * perf: Applied phpcs and phpmd rules BREAKING CHANGE: Code is refactored based on phpcs and phpmd rules. * Fixed phpcs issues in AttributeSlugRepository * chore(release): 6.0.0-beta.1 [skip ci] # [6.0.0-beta.1](v5.8.3...v6.0.0-beta.1) (2024-03-29) ### Performance Improvements * Applied phpcs and phpmd rules ([9a499fd](9a499fd)) ### BREAKING CHANGES * Code is refactored based on phpcs and phpmd rules. * feat: searchable filters (#166) When the filtersearch option is enabled within Tweakwise for a specific filter in the filter template, a search box will now appear above the filter. This search box allows users to conveniently search through the filter values associated with that particular filter. In cases where no filters are found, the designated text for displaying no results as configured in Tweakwise will be shown. Additionally, users have the option to specify placeholder text for the search box within Tweakwise. These modifications have been implemented within the default filter view. If you have customized your own view, please ensure to incorporate these changes accordingly. * chore(release): 6.0.0-beta.2 [skip ci] # [6.0.0-beta.2](v6.0.0-beta.1...v6.0.0-beta.2) (2024-04-09) ### Features * searchable filters ([#166](#166)) ([bebd6c6](bebd6c6)) * Fix spacing * Add filterpath to url if url no filter exists (#169) * Bump version nr --------- Co-authored-by: Tjeu Jansen <161043478+jansentjeu@users.noreply.github.com> Co-authored-by: tjeujansen <tjansen@emico.nl> Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attribute values have different spellings (Black and Black"), that may cause filters to return no products.
How to Reproduce the Issue:
tweakwise_attribute_slug
table. This may cause (depending on the order) to cause an tweakwise filter with the same value to return no products.How to test
Solution Implemented in the Pull Request:
To address this issue, the pull request introduces a fix by appending an extra dash and an number at the end of the slug value. This ensures that the slug value remains unique at all times. To fix duplicate values the only thing the customer has to do is to save the attribute with duplicate values.