Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme fails to render website due to not generated Resources #2

Closed
onedrawingperday opened this issue Sep 7, 2018 · 26 comments
Closed

Comments

@onedrawingperday
Copy link

onedrawingperday commented Sep 7, 2018

Hi @EmielH

It seems that your recent commit 40be04b has broken your theme demo on the Hugo Site.

When I execute the Themes Site Build Script there is the following error despite the committed /resources/ directory:

ERROR 2018/09/07 21:14:52 error: failed to transform resource: TOCSS: failed to transform "scss/tale.scss" (text/x-scss): this feature is not available in your current Hugo version

You theme's demo was once again generated when I reverted your commit so that line 21 of your head.html partial reads as follows:
{{ $style := resources.Get "scss/tale.scss" | toCSS | minify }}

Can you please look into this?

Thanks.


CC / @digitalcraftsman

@EmielH
Copy link
Owner

EmielH commented Sep 7, 2018

Hi @onedrawingperday

Thanks for letting me know! Unfortunately I don't have time this weekend, but I'll look into this as soon as possible. My guess is that since I changed the file name to I should have committed an updated resources directory as well.

EmielH added a commit that referenced this issue Sep 13, 2018
@EmielH
Copy link
Owner

EmielH commented Sep 13, 2018

@onedrawingperday Could you please check if my commit fixes this issue?

@onedrawingperday
Copy link
Author

@EmielH

The demo is generated now when I execute the Build Script.

It will be available again on the website once the theme submodule is updated.

Thanks!

@digitalcraftsman
Copy link

I've updated the themes (including your's). The demo is now up and running again.

@yanzhenjie
Copy link

The latest version has this problem again, the error message is as follows, what should I do?

Building sites … ERROR 2018/11/14 12:45:54 error: 
failed to transform resource: TOCSS: 
failed to transform "scss/tale.scss" (text/x-scss): this feature is not availablein your 
current Hugo version

@EmielH
Copy link
Owner

EmielH commented Nov 14, 2018

@yanzhenjie The fastest fix is to install the extended edition of Hugo. I hope I'll have time to generate new generated CSS files and commit them to the repository later today.

I'm curious why this happened because I haven't changed anything related to CSS/SCSS in the last few months.

@onedrawingperday
Copy link
Author

onedrawingperday commented Nov 14, 2018

@EmielH
I cloned your theme after the above comment to test and I am not getting the ERROR that @yanzhenjie reports.


Also since I'm here I would like to let you know that the README of the Hugo Themes repository was updated recently.

Apparently the use of .RelPermalink in the templates for Hugo Pipes Resources is a temporary workaround due to bug gohugoio/hugo#5226 once this bug is resolved this fix might need to change in your theme's templates once again. It would be a good thing if you could keep track of the above issue and update your theme's templates once a fix is out.

Thanks!

@EmielH
Copy link
Owner

EmielH commented Nov 14, 2018

@onedrawingperday Thanks for the heads up, I subscribed to the issue you mentioned! In the meantime I'm going to set up Travis CI to make sure the theme doesn't break when using the regular version of Hugo.

@EmielH
Copy link
Owner

EmielH commented Nov 14, 2018

@onedrawingperday Just to let you know: the automated build I set up using Travis CI does fail when using the regular Hugo version. See https://travis-ci.com/EmielH/tale-hugo/builds/91407129

I'm not exactly sure why the current generated CSS files are no longer working since I don't believe that I've changed anything pertaining to CSS or SCSS at all.

@onedrawingperday
Copy link
Author

@EmielH
I tested locally and for me there is no failure with the basic version of Hugo.

Here is the output

~/Desktop/tale-test$ git clone https://github.com/gohugoio/hugoBasicExample.git
Cloning into 'hugoBasicExample'...
remote: Enumerating objects: 172, done.
remote: Total 172 (delta 0), reused 0 (delta 0), pack-reused 172
Receiving objects: 100% (172/172), 3.15 MiB | 1.25 MiB/s, done.
Resolving deltas: 100% (45/45), done.
~/Desktop/tale-test$ cd hugoBasicExample
~/Desktop/tale-test/hugoBasicExample$ git submodule add -f https://github.com/EmielH/tale-hugo.git themes/tale
Cloning into '/tale-test/hugoBasicExample/themes/tale'...
remote: Enumerating objects: 68, done.
remote: Counting objects: 100% (68/68), done.
remote: Compressing objects: 100% (43/43), done.
remote: Total 260 (delta 32), reused 51 (delta 22), pack-reused 192
Receiving objects: 100% (260/260), 361.92 KiB | 726.00 KiB/s, done.
Resolving deltas: 100% (114/114), done.
~/Desktop/tale-test/hugoBasicExample$ hugo -t tale

                   | EN  
+------------------+----+
  Pages            | 29  
  Paginator pages  |  3  
  Non-page files   |  0  
  Static files     |  4  
  Processed images |  0  
  Aliases          | 12  
  Sitemaps         |  1  
  Cleaned          |  0  

Total in 212 ms
~/Desktop/tale-test/hugoBasicExample$ hugo version
Hugo Static Site Generator v0.52-DEV-5570A6E4:CHROMA-1B755A9 linux/amd64 BuildDate: 2018-11-12T19:16:06+0200

I think that you need to open an issue at the Hugo Forum about Travis CI failing to generate the Basic Example of Hugo with your theme.

There are others in the Forum who might help you with this that are more experienced with Travis CI than me.

@EmielH
Copy link
Owner

EmielH commented Nov 14, 2018

@onedrawingperday Thanks a lot for your help! Generating my own site works perfectly fine on my local machine with the basic version too. Of course I could have tested this earlier, before bothering you again...

@yanzhenjie Is your problem solved yet? Are you using the newest version of Hugo? If not, could you create a new issue? Asking on the Hugo Forum (https://discourse.gohugo.io/) might be a good idea too, since it seems your issue is not related to the theme.

@EmielH
Copy link
Owner

EmielH commented Nov 14, 2018

@chaudum
Copy link

chaudum commented Jan 27, 2019

I have the same issue, but when serving a site on my local machine:

$ hugo version
Hugo Static Site Generator v0.53-8FC339DC2529FF77E494A1C12CD1FF9FBCB880A4 linux/amd64 BuildDate: 2018-12-24T08:26:10Z
$ hugo new site test
Congratulations! Your new Hugo site is created in /home/christian/test.

Just a few more steps and you're ready to go:

1. Download a theme into the same-named folder.
   Choose a theme from https://themes.gohugo.io/, or
   create your own with the "hugo new theme <THEMENAME>" command.
2. Perhaps you want to add some content. You can add single files
   with "hugo new <SECTIONNAME>/<FILENAME>.<FORMAT>".
3. Start the built-in live server via "hugo server".

Visit https://gohugo.io/ for quickstart guide and full documentation.
$ cd test 
$ git clone https://github.com/EmielH/tale-hugo.git themes/tale
Cloning into 'themes/tale'...
remote: Enumerating objects: 9, done.
remote: Counting objects: 100% (9/9), done.
remote: Compressing objects: 100% (9/9), done.
remote: Total 290 (delta 1), reused 4 (delta 0), pack-reused 281
Receiving objects: 100% (290/290), 365.45 KiB | 1.19 MiB/s, done.
Resolving deltas: 100% (129/129), done.
$ nvim config.toml # theme="tale"
$ hugo serve 
Building sites … ERROR 2019/01/27 08:45:15 error: failed to transform resource: TOCSS: failed to transform "scss/tale.scss" (text/x-scss): this feature is not available in your current Hugo version
Total in 3 ms
Error: Error building site: logged 1 error(s)

Building the site works, though:

$ hugo 

                   | EN  
+------------------+----+
  Pages            |  6  
  Paginator pages  |  0  
  Non-page files   |  0  
  Static files     |  3  
  Processed images |  0  
  Aliases          |  3  
  Sitemaps         |  1  
  Cleaned          |  0  

Total in 16 ms

@digitalcraftsman
Copy link

@chaudum you've to use the "extended" version of Hugo which includes a processor for SCSS files. The output of hugo version tells me that you're only using the "normal" version of Hugo.

@onedrawingperday
Copy link
Author

onedrawingperday commented Jan 27, 2019

@EmielH I see that in commit 0ec8697 you committed only resources/_gen/assets/scss/scss/tale.scss_33d66d0b5f8b04b1d41c1da7ba50ddae.content and not the generated JSON hence your theme fails to render a website locally if the user is only on the Basic Version of Hugo.

Whenever you update the SCSS you need generate the resources as described here

Always delete the previous generated SCSS Resources directory and commit the new one. Never selectively update the .content or .JSON files because this issue will be recurring.

Once you look into this please let me know so that I can test your theme and close this issue again.

Thanks.

@onedrawingperday onedrawingperday changed the title Theme Demo on Hugo Site does not generate Theme fails to render website due to not generated Resources Jan 27, 2019
@EmielH
Copy link
Owner

EmielH commented Jan 27, 2019

@onedrawingperday Thanks for your assistance! I did not commit the .json file - or, more specifically, git wouldn't stage the file - because it hadn't changed. I just generated the .json and .content files again, just to be sure, and the .json file is still the same.

This is the content of the newly generated .json file:

{"Target":"css/style.css","MediaType":"text/css","Data":{}}

This matches the content of https://github.com/EmielH/tale-hugo/blob/master/resources/_gen/assets/scss/scss/tale.scss_33d66d0b5f8b04b1d41c1da7ba50ddae.json

What could be the problem here?

@onedrawingperday
Copy link
Author

onedrawingperday commented Jan 27, 2019

@EmielH

I installed Hugo Extended to regenerate your theme's resources:

First of all I moved the directory that is currently committed in your repo somewhere outside.

The new resources have a different hash than the old so it seems that something changed in the SCSS at some point and the resources were not regerated.

Currently your theme's demo is generated on the Hugo website (don't know why).

But locally a user like @chaudum who is on Hugo Basic will not be able to render a site.

I suggest that you delete existing resources, regenerate and commit.

Also I am posting the long output of the diff command between tale.scss_5ad6f408b0e3e473c748aac88af0ea18.content that I generated locally and tale.scss_33d66d0b5f8b04b1d41c1da7ba50ddae.content that is currently committed in the repo

It looks like you added minify at some point:

Click to expand the diff command output

diff tale.scss_5ad6f408b0e3e473c748aac88af0ea18.content tale.scss_33d66d0b5f8b04b1d41c1da7ba50ddae.content
1,520c1
< * {
<   -webkit-box-sizing: border-box;
<   -moz-box-sizing: border-box;
<   box-sizing: border-box;
<   line-height: 1.5; }
< 
< html,
< body {
<   color: #555;
<   margin: 0;
<   padding: 0; }
< 
< html {
<   font-family: "Libre Baskerville", "Times New Roman", Times, serif;
<   font-size: 14px;
<   overflow-y: scroll; }
<   @media (min-width: 600px) {
<     html {
<       font-size: 16px; } }
< 
< body {
<   -webkit-text-size-adjust: 100%; }
< 
< h1,
< h2,
< h3,
< h4,
< h5,
< h6 {
<   color: #353535;
<   font-family: "Helvetica Neue", "Segoe UI", Helvetica, Arial, sans-serif;
<   line-height: normal; }
< 
< a {
<   color: #4a9ae1;
<   text-decoration: none; }
< 
< blockquote {
<   border-left: 0.25rem solid #e5e5e5;
<   color: #979797;
<   margin: .8rem 0;
<   padding: .5rem 1rem; }
<   blockquote p:last-child {
<     margin-bottom: 0; }
<   @media (min-width: 600px) {
<     blockquote {
<       padding: 0 5rem 0 1.25rem; } }
< 
< img {
<   display: block;
<   margin: 0 0 1rem;
<   max-width: 100%; }
< 
< td {
<   vertical-align: top; }
< 
< pre,
< code {
<   font-family: Menlo, Monaco, monospace; }
< 
< code {
<   background-color: #f9f9f9;
<   border-radius: 3px;
<   color: #bf616a;
<   font-size: 85%;
<   padding: .25em .5em; }
< 
< pre {
<   margin: 0 0 1rem; }
< 
< pre code {
<   background-color: transparent;
<   color: inherit;
<   font-size: 100%;
<   padding: 0; }
< 
< .highlight {
<   background-color: #f9f9f9;
<   border-radius: 3px;
<   line-height: 1.4;
<   margin: 0 0 1rem;
<   padding: 1rem; }
<   .highlight pre {
<     margin-bottom: 0;
<     overflow-x: auto; }
<   .highlight .lineno {
<     color: #aaa;
<     display: inline-block;
<     padding: 0 .75rem 0 .25rem;
<     -webkit-user-select: none;
<     -moz-user-select: none;
<     user-select: none; }
< 
< .post {
<   padding: 3rem 0; }
<   .post-info {
<     color: #aaa;
<     font-family: Palatino, "Palatino LT STD", "Palatino Linotype", "Book Antiqua", "Georgia", serif;
<     letter-spacing: 0.5px;
<     text-align: center; }
<     .post-info span {
<       font-style: italic; }
<   .post-title {
<     color: #353535;
<     font-family: "Helvetica Neue", "Segoe UI", Helvetica, Arial, sans-serif;
<     font-size: 4rem;
<     margin: 1rem 0;
<     text-align: center; }
<   .post-line {
<     border-top: 0.4rem solid #353535;
<     display: block;
<     margin: 0 auto 3rem;
<     width: 4rem; }
<   .post p {
<     margin: 0 0 1rem;
<     text-align: justify; }
<   .post a:hover {
<     text-decoration: underline; }
<   .post img {
<     margin: 0 auto 0.5rem; }
<   .post img + em {
<     color: #aaa;
<     display: block;
<     font-family: "Helvetica Neue", "Segoe UI", Helvetica, Arial, sans-serif;
<     font-size: 0.9rem;
<     font-style: normal;
<     text-align: center; }
<   .post img.emoji {
<     display: inline-block;
<     left: 0;
<     transform: none;
<     width: 1rem;
<     height: 1rem;
<     vertical-align: text-top;
<     padding: 0;
<     margin: 0; }
< 
< .highlight .hll {
<   background-color: #ffc; }
< 
< .highlight .c {
<   color: #999; }
< 
< /* Comment */
< .highlight .err {
<   color: #a00;
<   background-color: #faa; }
< 
< /* Error */
< .highlight .k {
<   color: #069; }
< 
< /* Keyword */
< .highlight .o {
<   color: #555; }
< 
< /* Operator */
< .highlight .cm {
<   color: #09f;
<   font-style: italic; }
< 
< /* Comment.Multiline */
< .highlight .cp {
<   color: #099; }
< 
< /* Comment.Preproc */
< .highlight .c1 {
<   color: #999; }
< 
< /* Comment.Single */
< .highlight .cs {
<   color: #999; }
< 
< /* Comment.Special */
< .highlight .gd {
<   background-color: #fcc;
<   border: 1px solid #c00; }
< 
< /* Generic.Deleted */
< .highlight .ge {
<   font-style: italic; }
< 
< /* Generic.Emph */
< .highlight .gr {
<   color: #f00; }
< 
< /* Generic.Error */
< .highlight .gh {
<   color: #030; }
< 
< /* Generic.Heading */
< .highlight .gi {
<   background-color: #cfc;
<   border: 1px solid #0c0; }
< 
< /* Generic.Inserted */
< .highlight .go {
<   color: #aaa; }
< 
< /* Generic.Output */
< .highlight .gp {
<   color: #009; }
< 
< /* Generic.Prompt */
< /* Generic.Strong */
< .highlight .gu {
<   color: #030; }
< 
< /* Generic.Subheading */
< .highlight .gt {
<   color: #9c6; }
< 
< /* Generic.Traceback */
< .highlight .kc {
<   color: #069; }
< 
< /* Keyword.Constant */
< .highlight .kd {
<   color: #069; }
< 
< /* Keyword.Declaration */
< .highlight .kn {
<   color: #069; }
< 
< /* Keyword.Namespace */
< .highlight .kp {
<   color: #069; }
< 
< /* Keyword.Pseudo */
< .highlight .kr {
<   color: #069; }
< 
< /* Keyword.Reserved */
< .highlight .kt {
<   color: #078; }
< 
< /* Keyword.Type */
< .highlight .m {
<   color: #f60; }
< 
< /* Literal.Number */
< .highlight .s {
<   color: #d44950; }
< 
< /* Literal.String */
< .highlight .na {
<   color: #4f9fcf; }
< 
< /* Name.Attribute */
< .highlight .nb {
<   color: #366; }
< 
< /* Name.Builtin */
< .highlight .nc {
<   color: #0a8; }
< 
< /* Name.Class */
< .highlight .no {
<   color: #360; }
< 
< /* Name.Constant */
< .highlight .nd {
<   color: #99f; }
< 
< /* Name.Decorator */
< .highlight .ni {
<   color: #999; }
< 
< /* Name.Entity */
< .highlight .ne {
<   color: #c00; }
< 
< /* Name.Exception */
< .highlight .nf {
<   color: #c0f; }
< 
< /* Name.Function */
< .highlight .nl {
<   color: #99f; }
< 
< /* Name.Label */
< .highlight .nn {
<   color: #0cf; }
< 
< /* Name.Namespace */
< .highlight .nt {
<   color: #2f6f9f; }
< 
< /* Name.Tag */
< .highlight .nv {
<   color: #033; }
< 
< /* Name.Variable */
< .highlight .ow {
<   color: #000; }
< 
< /* Operator.Word */
< .highlight .w {
<   color: #bbb; }
< 
< /* Text.Whitespace */
< .highlight .mf {
<   color: #f60; }
< 
< /* Literal.Number.Float */
< .highlight .mh {
<   color: #f60; }
< 
< /* Literal.Number.Hex */
< .highlight .mi {
<   color: #f60; }
< 
< /* Literal.Number.Integer */
< .highlight .mo {
<   color: #f60; }
< 
< /* Literal.Number.Oct */
< .highlight .sb {
<   color: #c30; }
< 
< /* Literal.String.Backtick */
< .highlight .sc {
<   color: #c30; }
< 
< /* Literal.String.Char */
< .highlight .sd {
<   color: #c30;
<   font-style: italic; }
< 
< /* Literal.String.Doc */
< .highlight .s2 {
<   color: #c30; }
< 
< /* Literal.String.Double */
< .highlight .se {
<   color: #c30; }
< 
< /* Literal.String.Escape */
< .highlight .sh {
<   color: #c30; }
< 
< /* Literal.String.Heredoc */
< .highlight .si {
<   color: #a00; }
< 
< /* Literal.String.Interpol */
< .highlight .sx {
<   color: #c30; }
< 
< /* Literal.String.Other */
< .highlight .sr {
<   color: #3aa; }
< 
< /* Literal.String.Regex */
< .highlight .s1 {
<   color: #c30; }
< 
< /* Literal.String.Single */
< .highlight .ss {
<   color: #fc3; }
< 
< /* Literal.String.Symbol */
< .highlight .bp {
<   color: #366; }
< 
< /* Name.Builtin.Pseudo */
< .highlight .vc {
<   color: #033; }
< 
< /* Name.Variable.Class */
< .highlight .vg {
<   color: #033; }
< 
< /* Name.Variable.Global */
< .highlight .vi {
<   color: #033; }
< 
< /* Name.Variable.Instance */
< .highlight .il {
<   color: #f60; }
< 
< /* Literal.Number.Integer.Long */
< .css .o,
< .css .o + .nt,
< .css .nt + .nt {
<   color: #999; }
< 
< .container {
<   margin: 0 auto;
<   max-width: 800px;
<   width: 80%; }
< 
< main,
< footer,
< .nav-container {
<   display: block;
<   margin: 0 auto;
<   max-width: 800px;
<   width: 80%; }
< 
< .nav {
<   box-shadow: 0 2px 2px -2px rgba(0, 0, 0, 0.2);
<   overflow: auto; }
<   .nav-container {
<     margin: 1rem auto;
<     position: relative;
<     text-align: center; }
<   .nav-title {
<     -webkit-transition: all 0.2s ease-out;
<     -moz-transition: all 0.2s ease-out;
<     transition: all 0.2s ease-out;
<     color: #555;
<     display: inline-block;
<     margin: 0;
<     padding-right: .2rem; }
<     .nav-title:hover, .nav-title:focus {
<       opacity: .6; }
<   .nav ul {
<     list-style-type: none;
<     margin: 1rem 0 0;
<     padding: 0;
<     text-align: center; }
<   .nav li {
<     -webkit-transition: all 0.2s ease-out;
<     -moz-transition: all 0.2s ease-out;
<     transition: all 0.2s ease-out;
<     color: #555;
<     display: inline-block;
<     opacity: .6;
<     padding: 0 2rem 0 0; }
<     .nav li:last-child {
<       padding-right: 0; }
<     .nav li:hover, .nav li:focus {
<       opacity: 1; }
<   .nav a {
<     color: #555;
<     font-family: "Helvetica Neue", "Segoe UI", Helvetica, Arial, sans-serif; }
< 
< @media (min-width: 600px) {
<   .nav-container {
<     text-align: left; }
<   .nav ul {
<     bottom: 0;
<     position: absolute;
<     right: 0; } }
< 
< footer {
<   font-family: Palatino, "Palatino LT STD", "Palatino Linotype", "Book Antiqua", "Georgia", serif;
<   padding: 2rem 0;
<   text-align: center; }
<   footer span {
<     color: #555;
<     font-size: .8rem; }
< 
< .pagination {
<   border-top: 0.5px solid #e5e5e5;
<   font-family: Palatino, "Palatino LT STD", "Palatino Linotype", "Book Antiqua", "Georgia", serif;
<   padding-top: 2rem;
<   position: relative;
<   text-align: center; }
<   .pagination span {
<     color: #353535;
<     font-size: 1.1rem; }
<   .pagination .top {
<     -webkit-transition: all 0.3s ease-out;
<     -moz-transition: all 0.3s ease-out;
<     transition: all 0.3s ease-out;
<     color: #555;
<     font-family: "Helvetica Neue", "Segoe UI", Helvetica, Arial, sans-serif;
<     font-size: 1.1rem;
<     opacity: .6; }
<     .pagination .top:hover {
<       opacity: 1; }
<   .pagination .arrow {
<     -webkit-transition: all 0.3s ease-out;
<     -moz-transition: all 0.3s ease-out;
<     transition: all 0.3s ease-out;
<     color: #555;
<     position: absolute; }
<     .pagination .arrow:hover, .pagination .arrow:focus {
<       opacity: .6;
<       text-decoration: none; }
<   .pagination .left {
<     left: 0; }
<   .pagination .right {
<     right: 0; }
< 
< .catalogue-item {
<   border-bottom: 1px solid #e5e5e5;
<   color: #555;
<   display: block;
<   padding: 2rem 0; }
<   .catalogue-item:hover .catalogue-line,
<   .catalogue-item:focus .catalogue-line {
<     width: 5rem; }
<   .catalogue-item:last-child {
<     border: 0; }
< 
< .catalogue-time {
<   color: #aaa;
<   font-family: Palatino, "Palatino LT STD", "Palatino Linotype", "Book Antiqua", "Georgia", serif;
<   letter-spacing: .5px; }
< 
< .catalogue-title {
<   color: #353535;
<   display: block;
<   font-family: "Helvetica Neue", "Segoe UI", Helvetica, Arial, sans-serif;
<   font-size: 2rem;
<   font-weight: 700;
<   margin: .5rem 0; }
< 
< .catalogue-line {
<   -webkit-transition: all 0.3s ease-out;
<   -moz-transition: all 0.3s ease-out;
<   transition: all 0.3s ease-out;
<   border-top: 0.2rem solid #353535;
<   display: block;
<   width: 2rem; }
< 
< /*# sourceMappingURL=style.css.map */
\ No newline at end of file
---
> *{-webkit-box-sizing:border-box;-moz-box-sizing:border-box;box-sizing:border-box;line-height:1.5}html,body{color:#555;margin:0;padding:0}html{font-family:"Libre Baskerville","Times New Roman",Times,serif;font-size:14px;overflow-y:scroll}@media (min-width: 600px){html{font-size:16px}}body{-webkit-text-size-adjust:100%}h1,h2,h3,h4,h5,h6{color:#353535;font-family:"Helvetica Neue","Segoe UI",Helvetica,Arial,sans-serif;line-height:normal}a{color:#4a9ae1;text-decoration:none}blockquote{border-left:0.25rem solid #e5e5e5;color:#979797;margin:.8rem 0;padding:.5rem 1rem}blockquote p:last-child{margin-bottom:0}@media (min-width: 600px){blockquote{padding:0 5rem 0 1.25rem}}img{display:block;margin:0 0 1rem;max-width:100%}td{vertical-align:top}pre,code{font-family:Menlo,Monaco,monospace}code{background-color:#f9f9f9;border-radius:3px;color:#bf616a;font-size:85%;padding:.25em .5em}pre{margin:0 0 1rem}pre code{background-color:transparent;color:inherit;font-size:100%;padding:0}.highlight{background-color:#f9f9f9;border-radius:3px;line-height:1.4;margin:0 0 1rem;padding:1rem}.highlight pre{margin-bottom:0;overflow-x:auto}.highlight .lineno{color:#aaa;display:inline-block;padding:0 .75rem 0 .25rem;-webkit-user-select:none;-moz-user-select:none;user-select:none}.post{padding:3rem 0}.post-info{color:#aaa;font-family:Palatino,"Palatino LT STD","Palatino Linotype","Book Antiqua","Georgia",serif;letter-spacing:0.5px;text-align:center}.post-info span{font-style:italic}.post-title{color:#353535;font-family:"Helvetica Neue","Segoe UI",Helvetica,Arial,sans-serif;font-size:4rem;margin:1rem 0;text-align:center}.post-line{border-top:0.4rem solid #353535;display:block;margin:0 auto 3rem;width:4rem}.post p{margin:0 0 1rem;text-align:justify}.post a:hover{text-decoration:underline}.post img{margin:0 auto 0.5rem}.post img+em{color:#aaa;display:block;font-family:"Helvetica Neue","Segoe UI",Helvetica,Arial,sans-serif;font-size:0.9rem;font-style:normal;text-align:center}.post img.emoji{display:inline-block;left:0;transform:none;width:1rem;height:1rem;vertical-align:text-top;padding:0;margin:0}.highlight .hll{background-color:#ffc}.highlight .c{color:#999}.highlight .err{color:#a00;background-color:#faa}.highlight .k{color:#069}.highlight .o{color:#555}.highlight .cm{color:#09f;font-style:italic}.highlight .cp{color:#099}.highlight .c1{color:#999}.highlight .cs{color:#999}.highlight .gd{background-color:#fcc;border:1px solid #c00}.highlight .ge{font-style:italic}.highlight .gr{color:#f00}.highlight .gh{color:#030}.highlight .gi{background-color:#cfc;border:1px solid #0c0}.highlight .go{color:#aaa}.highlight .gp{color:#009}.highlight .gu{color:#030}.highlight .gt{color:#9c6}.highlight .kc{color:#069}.highlight .kd{color:#069}.highlight .kn{color:#069}.highlight .kp{color:#069}.highlight .kr{color:#069}.highlight .kt{color:#078}.highlight .m{color:#f60}.highlight .s{color:#d44950}.highlight .na{color:#4f9fcf}.highlight .nb{color:#366}.highlight .nc{color:#0a8}.highlight .no{color:#360}.highlight .nd{color:#99f}.highlight .ni{color:#999}.highlight .ne{color:#c00}.highlight .nf{color:#c0f}.highlight .nl{color:#99f}.highlight .nn{color:#0cf}.highlight .nt{color:#2f6f9f}.highlight .nv{color:#033}.highlight .ow{color:#000}.highlight .w{color:#bbb}.highlight .mf{color:#f60}.highlight .mh{color:#f60}.highlight .mi{color:#f60}.highlight .mo{color:#f60}.highlight .sb{color:#c30}.highlight .sc{color:#c30}.highlight .sd{color:#c30;font-style:italic}.highlight .s2{color:#c30}.highlight .se{color:#c30}.highlight .sh{color:#c30}.highlight .si{color:#a00}.highlight .sx{color:#c30}.highlight .sr{color:#3aa}.highlight .s1{color:#c30}.highlight .ss{color:#fc3}.highlight .bp{color:#366}.highlight .vc{color:#033}.highlight .vg{color:#033}.highlight .vi{color:#033}.highlight .il{color:#f60}.css .o,.css .o+.nt,.css .nt+.nt{color:#999}.container{margin:0 auto;max-width:800px;width:80%}main,footer,.nav-container{display:block;margin:0 auto;max-width:800px;width:80%}.nav{box-shadow:0 2px 2px -2px rgba(0,0,0,0.2);overflow:auto}.nav-container{margin:1rem auto;position:relative;text-align:center}.nav-title{-webkit-transition:all 0.2s ease-out;-moz-transition:all 0.2s ease-out;transition:all 0.2s ease-out;color:#555;display:inline-block;margin:0;padding-right:.2rem}.nav-title:hover,.nav-title:focus{opacity:.6}.nav ul{list-style-type:none;margin:1rem 0 0;padding:0;text-align:center}.nav li{-webkit-transition:all 0.2s ease-out;-moz-transition:all 0.2s ease-out;transition:all 0.2s ease-out;color:#555;display:inline-block;opacity:.6;padding:0 2rem 0 0}.nav li:last-child{padding-right:0}.nav li:hover,.nav li:focus{opacity:1}.nav a{color:#555;font-family:"Helvetica Neue","Segoe UI",Helvetica,Arial,sans-serif}@media (min-width: 600px){.nav-container{text-align:left}.nav ul{bottom:0;position:absolute;right:0}}footer{font-family:Palatino,"Palatino LT STD","Palatino Linotype","Book Antiqua","Georgia",serif;padding:2rem 0;text-align:center}footer span{color:#555;font-size:.8rem}.pagination{border-top:0.5px solid #e5e5e5;font-family:Palatino,"Palatino LT STD","Palatino Linotype","Book Antiqua","Georgia",serif;padding-top:2rem;position:relative;text-align:center}.pagination span{color:#353535;font-size:1.1rem}.pagination .top{-webkit-transition:all 0.3s ease-out;-moz-transition:all 0.3s ease-out;transition:all 0.3s ease-out;color:#555;font-family:"Helvetica Neue","Segoe UI",Helvetica,Arial,sans-serif;font-size:1.1rem;opacity:.6}.pagination .top:hover{opacity:1}.pagination .arrow{-webkit-transition:all 0.3s ease-out;-moz-transition:all 0.3s ease-out;transition:all 0.3s ease-out;color:#555;position:absolute}.pagination .arrow:hover,.pagination .arrow:focus{opacity:.6;text-decoration:none}.pagination .left{left:0}.pagination .right{right:0}.catalogue-item{border-bottom:1px solid #e5e5e5;color:#555;display:block;padding:2rem 0}.catalogue-item:hover .catalogue-line,.catalogue-item:focus .catalogue-line{width:5rem}.catalogue-item:last-child{border:0}.catalogue-time{color:#aaa;font-family:Palatino,"Palatino LT STD","Palatino Linotype","Book Antiqua","Georgia",serif;letter-spacing:.5px}.catalogue-title{color:#353535;display:block;font-family:"Helvetica Neue","Segoe UI",Helvetica,Arial,sans-serif;font-size:2rem;font-weight:700;margin:.5rem 0}.catalogue-line{-webkit-transition:all 0.3s ease-out;-moz-transition:all 0.3s ease-out;transition:all 0.3s ease-out;border-top:0.2rem solid #353535;display:block;width:2rem}

@EmielH
Copy link
Owner

EmielH commented Jan 27, 2019

I did add minify at one point, using "outputStyle" "compressed" on line 21 of head.html. This is why tale.scss_33d66d0b5f8b04b1d41c1da7ba50ddae.content from the repo is minified.

I deleted the existing resources and regenerated them. The newly created .content file on my machine is the same as the one in the git repo. Its hash is the same too. I'm curious why your locally generated file has a different hash, and why it isn't minified.

I do however also see that hugo serve using Hugo Basic does not work, while hugo using Hugo Basic does. The fact that hugo still works is probably also why the theme's demo is still being generated on the Hugo website?

@EmielH
Copy link
Owner

EmielH commented Jan 27, 2019

Just as I posted the previous comment, I found the problem. It's in this line:

{{- $cssOptions := cond ($inServerMode) (dict "targetPath" $cssTarget "enableSourceMap" true) (dict "targetPath" $cssTarget "outputStyle" "compressed") }}

The CSS is not compressed when running in server mode, i.e. using hugo serve, to make debugging easier. However, .content and .json files for this uncompressed CSS have not been added to the repo.

I will commit the uncompressed CSS to the repo.

  • I'm thinking of a way to add this to Travis CI, since hugo serve does not terminate if everything works correctly.
  • I'm also thinking of writing a script that automates resource creation and copying the resources over from the site to the theme, that can be run every time before a commit, to prevent problems like this in the future. The workflow here could be improved.

@onedrawingperday
Copy link
Author

@EmielH

Glad you found it. I was about to post the same.

I do have a question though. How do minify the stylesheet? You are not using Hugo's minify pipeline as far as I can tell. And you really should.

Have a look over here: https://gohugo.io/hugo-pipes/minification/#readout

@EmielH
Copy link
Owner

EmielH commented Jan 27, 2019

I'm using outputStyle compressed, as documented here. At the bottom, it says:

Setting outputStyle to compressed will handle SASS/SCSS files minification better than the more generic resources.Minify.

@onedrawingperday
Copy link
Author

onedrawingperday commented Jan 27, 2019

Right. I missed that one because in my workflow I do not rely on SASS/SCSS.

Thank you for issuing a fix your theme will be updated on the website the next time that @digitalcraftsman updates the themes in the repository.

If anything else comes up I will let you know.

@chaudum You should pull the latest changes to resolve the problem you encountered.

@EmielH
Copy link
Owner

EmielH commented Jan 27, 2019

@onedrawingperday Thanks again for your help!

@onedrawingperday
Copy link
Author

@EmielH You're welcome. Also thank you for pointing out something that I hadn't noticed.

@chaudum
Copy link

chaudum commented Jan 27, 2019

@chaudum You should pull the latest changes to resolve the problem you encountered.

Works like charm. Thanks a lot! Tale is a great theme :)

@digitalcraftsman
Copy link

Thank you for issuing a fix your theme will be updated on the website the next time that @digitalcraftsman updates the themes in the repository.

All themes have been updated a moment ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants