Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate switching out zlib-ng for libdeflate #67

Closed
EmilDohne opened this issue Apr 5, 2024 · 0 comments · Fixed by #72
Closed

Investigate switching out zlib-ng for libdeflate #67

EmilDohne opened this issue Apr 5, 2024 · 0 comments · Fixed by #72
Labels
c++ enhancement New feature or request

Comments

@EmilDohne
Copy link
Owner

From the benchmarks presented here zlib-ng/zlib-ng#1486 it appears that even for larger buffers libdeflate outperforms zlib-ng on both compression ratios as well as speed.

It does provide a different api than zlib-ng and also doesnt support streaming which are both not necessarily concerns for our use cases.
@EmilDohne EmilDohne added enhancement New feature or request c++ labels Apr 5, 2024
@EmilDohne EmilDohne linked a pull request May 27, 2024 that will close this issue
67 investigate switching out zlib ng for libdeflate #72
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c++ enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

67 investigate switching out zlib ng for libdeflate EmilDohne/PhotoshopAPI
1 participant
@EmilDohne