67 investigate switching out zlib ng for libdeflate #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…D intrinsics as well as more efficient parsing
…ue ref but just a ref instead since passing an r-value ref made no sense without storing it
… changing includes after refactor
… resulting in speedups
…fer instead of allocating and returning the buffer
…ce that is more appropriate
…e difference between all configurations was roughly equal
ubuntu-latest -> ubuntu-24.04 macos-latest -> macos-13 macos-14 -> macos-latest
…has no support for exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turned out to be quite a large PR as I took this moment to refactor a lot of the compression code and optimize the way the PhotoshopAPI internally compresses and decompresses data by reusing a swap buffer rather than reallocating buffers only to discard them away later.
Additionally we now use libdeflate rather than zlib_ng for compression and decompression as this allows for much greater decompression speeds. We also added memory-mapped files for read operations as this provided significant improvement in read performance.
Overall the speedups are:
While 32-bit reads did get slightly slower with our benchmark data we did see speedups in all other cases which justifies this change. I will look into equalizing 32-bit read speeds in the future