refactor: fix context vars missing in isolated slot #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuroOravec
force-pushed
the
jo-fix-slot-isolation-ctx-top-lvl
branch
from
c47460d
to
c55016e
Compare
JuroOravec
commented
Apr 24, 2024
| @@ -19,11 +20,17 @@ | |||
| _FILLED_SLOTS_CONTENT_CONTEXT_KEY = "_DJANGO_COMPONENTS_FILLED_SLOTS" | |||
| _OUTER_ROOT_CTX_CONTEXT_KEY = "_DJANGO_COMPONENTS_OUTER_ROOT_CTX" | |||
| _SLOT_COMPONENT_ASSOC_KEY = "_DJANGO_COMPONENTS_SLOT_COMP_ASSOC" | |||
| _PARENT_COMP_KEY = "_DJANGO_COMPONENTS_PARENT_COMP" | |||
| _CURRENT_COMP_KEY = "_DJANGO_COMPONENTS_CURRENT_COMP" | |||
There was a problem hiding this comment.
On the Context object we now store the ID of the current component node that we're rendering, as well as it's parent.
The parent info is used in this MR as an indicator of whether the rendered component node is a top-level node, or it is inside another component.
If I remember right, the info on current component ID is / will be used to fix #453
JuroOravec
commented
Apr 24, 2024
| outer_ctx | ||
| and not context.get(_PARENT_COMP_KEY) | ||
| and app_settings.SLOT_CONTEXT_BEHAVIOR == SlotContextBehavior.ISOLATED | ||
| and _OUTER_ROOT_CTX_CONTEXT_KEY in context # <-- Added to avoid breaking tests |
There was a problem hiding this comment.
As the comment says, the last line was added to avoid breaking other tests (not quite sure why)
dylanjcastillo
approved these changes
Apr 25, 2024
|
Nice fix. But really looking forward to merging the two options and just keeping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #454