feat: Support both sync and async in ComponentDependencyMiddleware #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
Well, that looks like I've broken something :) Let me take a look why the tests are failing. |
JuroOravec
reviewed
May 1, 2024
src/django_components/middleware.py
Outdated
| response = self.get_response(request) | ||
| response = self.process_response(request) |
There was a problem hiding this comment.
Ah, maybe the issue is that we pass request here instead of response?
There was a problem hiding this comment.
That'd do it :) Hopefully it's working with that change
|
@TheSteveBurgess thanks a lot for the PR! 🚀 It looks great! There's one typo, let's see if things work after that :) |
JuroOravec
reviewed
May 1, 2024
JuroOravec
reviewed
May 1, 2024
Co-authored-by: Juro Oravec <juraj.oravec.josefson@gmail.com>
Co-authored-by: Juro Oravec <juraj.oravec.josefson@gmail.com>
|
I ran the tests locally, everything should be passing after fixing the function signatures |
JuroOravec
changed the title
|
Amazing! Thanks for that :) |
|
Merged! @TheSteveBurgess thanks a lot again :) I plan to release this as part of v0.70 together with #465 later today |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
PR for converting the middleware to async as mentioned here (#464)
This is working fine for me both sync and async via Daphne.