Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed class import #112

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Conversation

andizer
Copy link
Contributor

@andizer andizer commented Jan 3, 2024

I don't have the energy to fill in the entire pull request template.

The target class is already within the same. I removed the import of the non-existing one.

Cheers!

Context

  • Fixes a bug where a non-existing class was imported and used.

Summary

This PR can be summarized in the following changelog entry:

  • Fixes a bug where a non-existing class was imported and used.

Relevant technical choices:

Test instructions

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Block/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities.
  • I have added unit tests to verify the code works as intended.
  • I have checked that the base branch is correctly set.

Fixes #

@jdevalk jdevalk merged commit 48b2111 into Emilia-Capital:trunk Jan 3, 2024
11 checks passed
@andizer andizer deleted the fix-incorrect-import branch January 3, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants