Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display error on recent version of Windows 10/EDGE #3

Open
llaske opened this issue Apr 12, 2018 · 6 comments
Open

Display error on recent version of Windows 10/EDGE #3

llaske opened this issue Apr 12, 2018 · 6 comments

Comments

@llaske
Copy link
Contributor

llaske commented Apr 12, 2018

I'm working on final testing of Sugarizer v1.0. Unfortunately I've got an issue with your Sugarizer encapsulation of Scratch.
It seems that it don't works on recent version of Windows 10/EDGE. Most of the content is blank:

image

I've tested it few month ago and it perfectly worked but I guess something changed in the browser so the compatibility is broken now.
I've seen that recent version of Scratch v3 works on Windows 10/EDGE. So I would like to upgrade your encapsulation but I'm not familiar with the process describe in the README.
Could you help me on this? First, what's the command line to convert .jsx to .js? Did you use Grunt?

@EmilyOng
Copy link
Owner

EmilyOng commented Apr 12, 2018 via email

@llaske
Copy link
Contributor Author

llaske commented Apr 13, 2018

Could you share the script you've used to convert the whole Scratch project?

@EmilyOng
Copy link
Owner

EmilyOng commented Apr 13, 2018 via email

@llaske
Copy link
Contributor Author

llaske commented Apr 14, 2018

We'll be great. Thanks.

@EmilyOng
Copy link
Owner

EmilyOng commented Apr 17, 2018 via email

@llaske
Copy link
Contributor Author

llaske commented May 6, 2018

Hi Emily,
I've finally managed to fix the issue myself.
But it was complex because lot of code changed in Scratch v3 since your work. More specifically, all the logic to save the project has been totally reviewed using Promise.
I've published my change here and here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants