Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataParser: Implement a check for generated TimeSyncMap #101

Closed
nitin710 opened this issue Apr 15, 2022 · 1 comment · Fixed by #106
Closed

DataParser: Implement a check for generated TimeSyncMap #101

nitin710 opened this issue Apr 15, 2022 · 1 comment · Fixed by #106

Comments

@nitin710
Copy link
Collaborator

nitin710 commented Apr 15, 2022

Description

  • Right now, there is no check for the returned value of a timesync map

    timeSyncMap = calculateTimeSyncMap(allTimestampData);

  • In a case when a timeSyncMap cannot be generated, the parser should NOT CONTINUE TO PARSE values

    if (timestampData.size() < 2) {
    ofLogError() << "calculateTimeSyncMap: Less than 2 timestamps found. Unable to map timestamps to Epoch time." << endl;
    return tsMap;
    }

Proposed solution

nitin710 added a commit that referenced this issue Apr 20, 2022
@nitin710
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant