Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue with temp plot resetting time scale #184

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

nitin710
Copy link
Collaborator

@nitin710 nitin710 commented Mar 10, 2023

Description

  • fixed issue with temp plot resetting time scale
    • Previously, the change made to plot time window by pressing arrow keys was lost when EmotiBit was disconnected.

Requirements

  • None

Issues Referenced

Documentation update

  • None

Testing

To Test

  • Checkout the required branch and compile from source
  • run the application and connect to an EmotiBit.
  • Change the time window by pressing the arrow keys
  • disconnect from EmotiBit
  • Reconnect to EmotiBit/ connect to different EmotiBit
  • Observe the timeWindow. It should be same as the value set before disconnect.

Tests performed

Test Configuration:

  • EmotiBit software version: 1.7.2.fix-tempPlotTimeScale.0
Input Observation Result
Disconnect/connect with same emotibit timeWindow is maintained ✔️
Connect to different EmotiBit timeWindow is maintained ✔️
Switch between EmotiBit MD/EM timeWindow is maintained (even when plots go from 2 -> 1 ✔️

Checklist to allow merge

  • All dependent repositories used were on branch master
  • Software
    • Passed testing on Windows
    • Passed testing on macOS (very minor code change. not testing on macOS to avoid setup time cost)
    • Passed testing on linux (ubuntu)
  • Firmware
    • Set testingMode to TestingMode::NONE
    • Set const bool DIGITAL_WRITE_DEBUG = false (if set true while testing)
    • Update version in EmotiBit.h
    • Update library.properties to the correct version (should match EmotiBit.h)
  • Update software bundle version in ofxEmotiBitVersion.h
  • doxygen style comments included for new code snippets
  • Required documentation udpated

Screenshots:

Copy link
Collaborator

@produceconsumerobot produceconsumerobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review 01

Code looks good.
If you've tested it, merge it!

@nitin710 nitin710 merged commit 5ccac81 into master Apr 5, 2023
@nitin710 nitin710 deleted the fix-tempPlotTimeScale branch April 5, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EmotiBit Oscilloscope: Temp plot resets to 10sec timeline when switching between emotibits
2 participants