Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to data parser to accomodate daylight savings time #210

Merged
merged 4 commits into from
Jun 16, 2023

Conversation

nitin710
Copy link
Collaborator

@nitin710 nitin710 commented May 11, 2023

Description

  • Fixes daylight savings time adjustment on dataparser.
  • Currently, in locations following day light savings time, there appears to be a 1 hour offset between time of recording and parsing.

Requirements

  • None

Issues Referenced

Documentation update

None

Notes for Reviewer

Testing

Results

  • The table below shows that parsing the same file with DST enabled/disabled creates the correct epoch times to get back to the local time captured in the filename.
Operating system Daylight savings enabled daylight savings disabled
Windows 10 image image
macOS mojave image image
Linux Ubuntu 22.04 image image

Feature Tests

  • DataParser: Handles daylight savings time shift correctly

Steps to test

Import the steps from the EmotiBit Feature Test Protocol for quick access for the reviewer

Checklist to allow merge

  • All dependent repositories used were on branch master
  • Software
    • Get approval from the reviewer
    • Passed testing on Windows
    • Passed testing on macOS (for major changes/GUI changes/ PRs adding files distributed with the EmotiBit software)
    • Passed testing on linux (ubuntu) (for major changes/GUI changes/ PRs adding files distributed with the EmotiBit software)
    • Update software bundle version in ofxEmotiBitVersion.h
  • Required documentation updated

Screenshots:

@produceconsumerobot
Copy link
Collaborator

Review 01

@nitin710 looks good, ship it.

No tests run based on the clarity and completeness of the PR tests already run.

@nitin710 nitin710 merged commit b66ca7d into master Jun 16, 2023
@nitin710 nitin710 deleted the fix-parserDst branch June 16, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

init. provision for dayLightSavingsTime
2 participants