test admin dashboard #188
Merged
test admin dashboard #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noah10
requested changes
Mar 8, 2022
noah10
requested changes
Mar 9, 2022
There was a problem hiding this comment.
Thanks for the changes - they look good. I just noticed that there are no tests for the checkbox functionality, though. Could you please add some tests to confirm that the api client update function is called (with the expected date) when checking an unchecked box and that unchecking a box displays the confirmation and makes the appropriate update if the confirmation is OK'd?
also, avoid doing the zero-delay setTimeout thing it's not worth the complexity just to wait for the event to cancel
noah10
requested changes
Mar 14, 2022
| mriT1Cell.querySelector("input").dispatchEvent(new MouseEvent("click", {bubbles: true})); | ||
| // wait for the async click event handler to resolve | ||
| await new Promise(process.nextTick); | ||
| // Twilight Sparkle should now have a timestamp for MRI T1 |
There was a problem hiding this comment.
I think "now" is probably supposed to be "not" here.
There was a problem hiding this comment.
Nice catch! Just fixed it.
after the MRI T1 checkbox gets unchecked
noah10
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.