This repository has been archived by the owner on May 6, 2022. It is now read-only.
Refactoring pkg structure #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@EmpregoLigado/cabras can you 👀 |
|
👿 |
|
Sorry, I am not having time to check this lately 😞 |
|
I totally understand mate @efreesen |
|
@aalvesjr thx for reviewing, as this PR has some improvements I will only merge only after @hernandesbsousa and @efreesen review 👍 |
This was referenced Mar 25, 2017
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After collecting some feedback in go community and studying interested projects around github I realized that cron-srv could have a clear package separation like https://github.com/apex/apex does for example, so this Pull Request introduces:
✅ Refactor package structure
✅ Removes echo in favor of a tiny router library which satisfies http.Handler interface
✅ Make scheduler thread safe with lock/unlock
✅ Add capability to be multicore
✅ Extract runner object with channel based API
✅ Add tests for api routes
✅ Add tests for scheduler
✅ Add open source license