Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added translations for Japanese, Ryukyuan languages, Simplified Chinese, and Traditional Chinese #15

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Added translations for Japanese, Ryukyuan languages, Simplified Chinese, and Traditional Chinese #15

wants to merge 16 commits into from

Conversation

kuragehimekurara1
Copy link

Added translations for Japanese, Ryukyuan languages, Simplified Chinese, and Traditional Chinese

@kuragehimekurara1
Copy link
Author

https://en.wikipedia.org/wiki/Ryukyuan_languages?wprov=sfti1
If you don't understand Ryukyuan languages, please see this Wikipedia page.

@EmreTech
Copy link
Owner

EmreTech commented Dec 9, 2022

https://en.wikipedia.org/wiki/Ryukyuan_languages?wprov=sfti1 If you don't understand Ryukyuan languages, please see this Wikipedia page.

Thanks.

@EmreTech EmreTech added this to In progress in Calculator_NX Development via automation Dec 9, 2022
@EmreTech EmreTech added the enhancement New feature or request label Dec 9, 2022
EmreTech
EmreTech requested changes Dec 10, 2022
View reviewed changes
Copy link
Owner

@EmreTech EmreTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, Borealis only supports ja and not ja-JP & ja-RYU.

https://github.com/natinusala/borealis/blob/f15550e5a49e22fb55fa0d2ca524444146e65c29/library/include/borealis/core/i18n.hpp#L27-L44

@kuragehimekurara1
Copy link
Author

Does that mean that it only supports Japanese and not Ryukyuan languages?

@EmreTech
Copy link
Owner

I believe so.

@kuragehimekurara1
Copy link
Author

Removed Ryukyuan languages! 👍

@EmreTech
Copy link
Owner

One more thing: looking at the existing folders in the resources/i18n folder, you have to use dashes (-) instead of underscores (_).

@kuragehimekurara1
Copy link
Author

Excuse me. I was busy so I was able to send a reply. I will change it today or tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmreTech EmreTech EmreTech requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Calculator_NX Development
  
In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kuragehimekurara1 @EmreTech