Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brightness set to 100% after RetroArch #1136

Closed
gingerbeardman opened this issue Feb 15, 2023 · 8 comments
Closed

Brightness set to 100% after RetroArch #1136

gingerbeardman opened this issue Feb 15, 2023 · 8 comments

Comments

@gingerbeardman
Copy link

gingerbeardman commented Feb 15, 2023

Describe the bug
Brightness set to 100% after RetroArch

To Reproduce
Steps to reproduce the behavior:

  1. In ES: Start > System Settings > Brightness > 10%
  2. Run a game using RA
  3. Brightness is still at 10%
  4. Quit
  5. Brightness is now 100%

Expected behavior
Brightness should remain as set and not change unexpectedly

Screenshots
N/A

EmuELEC version:

  • Version: 4.6

Device (please complete the following information):

  • SOC: RK3326
  • Brand: GameForce
  • Model: Chi
  • Version: n/a

Additional context

  • I'm playing N64 games using Mupen64plus 32bit
  • I don't see any way of changing Brightness within RA?
@gingerbeardman
Copy link
Author

Resetting RetroArch config did nothing

@Langerz82
Copy link
Collaborator

Try in RA Settings >> Configuration >> Save on Exit.

Where are you changing brightness? I couldn't find the option in the main menu.

In /storage/.config/retroarch/retroarch.cfg you can manually change the number under:

screen_brightness = "100"

@Langerz82
Copy link
Collaborator

It seems it might reset in the code, as AmberELEC has a patch to disable the reset here:
https://github.com/AmberELEC/AmberELEC/blob/dev/packages/games/tools/retroarch/patches/retroarch-disable_brightness_setting.patch

@gingerbeardman
Copy link
Author

gingerbeardman commented Feb 16, 2023

Where are you changing brightness? I couldn't find the option in the main menu.

In ES: Start > System Settings > Brightness

/storage/.config/retroarch/retroarch.cfg

already I have screen_brightness = "10"

Sadly none of your suggestions are the solution.

What is strange is that I remember this being a problem when I first got my device, then it was solved, and now it is a problem again. IIRC

@Langerz82
Copy link
Collaborator

@shantigilbert
Will probably have to look into this one, because we usually have a patch that should disable the resetting of screen brightness located here:
packages/sx05re/libretro/retroarch/patches/OdroidGoAdvance/9999-emuelec-unify-brightness.patch

Gameforce should also use these patches. Maybe they are not applying properly.

@Langerz82
Copy link
Collaborator

I used an similar Odroid-Go Advance device and the brightness settings were being applied. Shanti might have to take a look at why Gameforce is not working the same.

@miwasp
Copy link

miwasp commented Feb 18, 2023

The patch still works fine for oga/ogs and gf, it just isn‘t applied to the 32bit version of retroarch. This needs to be fixed.

@gingerbeardman
Copy link
Author

gingerbeardman commented Feb 18, 2023

Aha! That would do it.

I am using 32-bit is that it's the only version that I could get to run Beetle Adventure Racing and look OK

shantigilbert pushed a commit that referenced this issue Feb 20, 2023
* Fix brightness reset on GF (issue #1136)

This is a fix for issue #1136.

* This time without option enable_odroidgo2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants