Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make glibc compilable for oga and gf #1129

Merged
merged 2 commits into from Feb 21, 2023
Merged

Make glibc compilable for oga and gf #1129

merged 2 commits into from Feb 21, 2023

Conversation

miwasp
Copy link

@miwasp miwasp commented Feb 14, 2023

I'm not sure if this is what it should be (maybe use a newer kernel instead?) but at least it compiles for oga and gf.

I'm not sure if this is what it should be (maybe use a newer kernel instead?) but at least it compiles for oga and gf.
@7Ji
Copy link
Collaborator

7Ji commented Feb 14, 2023

Is glibc also broken for other project/devices? If not then it shouldn't be dropped for all matching kernels and it's better to split it to another switch case.

Also, I wonder if lib32-glibc is also broken? Since it's kept in sync with regular glibc I'm afraid it is also broken now on gf/oga.

@miwasp
Copy link
Author

miwasp commented Feb 14, 2023

The switch case in lib32-glibc is exactly identical
amlogic-4.9|rockchip-4.4|gameforce-4.4|odroid-go-a-4.4|rk356x-4.19|OdroidM1-4.19)

I still have not fully compiled for oga or gf. Currently i had to revert ethtool from 6.1 to 6.0 because of unknown kernel symbols in 6.1. I will stop creating PR's for now until it fully compiled and i have an overview of all needed changes.

@shantigilbert
Copy link
Collaborator

I think a better fix (on both packages) would be:

  amlogic-4.9|rockchip-4.4|odroid-go-a-4.4|rk356x-4.19|OdroidM1-4.19)
    OPT_ENABLE_KERNEL=4.9.0
    ;;
 gameforce-4.4)
    OPT_ENABLE_KERNEL=4.4.0
    ;;

@miwasp
Copy link
Author

miwasp commented Feb 20, 2023

This would fix it for GF but not for OGA?

@shantigilbert
Copy link
Collaborator

Sorry I misunderstood I thought this was only got the GF, but if it happens on the OGA as well we should update the condition.

@miwasp
Copy link
Author

miwasp commented Feb 20, 2023

This concerns every system with a kernel version <4.9.0, so GF and OGA are definitely affected. What is „rockchip-4.4“ used for?

@shantigilbert
Copy link
Collaborator

Well then, we need to move the case for the OGA, GF and Rockchip.4.4 leave the rest there, since we do not know if this is needed, I know it's not needed for Amlogic-ng

shantigilbert pushed a commit that referenced this pull request Feb 21, 2023
@shantigilbert shantigilbert merged commit fa5095b into EmuELEC:dev Feb 21, 2023
@miwasp miwasp deleted the patch-2 branch February 21, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants