New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make glibc compilable for oga and gf #1129
Conversation
I'm not sure if this is what it should be (maybe use a newer kernel instead?) but at least it compiles for oga and gf.
Is glibc also broken for other project/devices? If not then it shouldn't be dropped for all matching kernels and it's better to split it to another switch case. Also, I wonder if lib32-glibc is also broken? Since it's kept in sync with regular glibc I'm afraid it is also broken now on gf/oga. |
The switch case in lib32-glibc is exactly identical I still have not fully compiled for oga or gf. Currently i had to revert ethtool from 6.1 to 6.0 because of unknown kernel symbols in 6.1. I will stop creating PR's for now until it fully compiled and i have an overview of all needed changes. |
I think a better fix (on both packages) would be:
|
This would fix it for GF but not for OGA? |
Sorry I misunderstood I thought this was only got the GF, but if it happens on the OGA as well we should update the condition. |
This concerns every system with a kernel version <4.9.0, so GF and OGA are definitely affected. What is „rockchip-4.4“ used for? |
Well then, we need to move the case for the OGA, GF and Rockchip.4.4 leave the rest there, since we do not know if this is needed, I know it's not needed for Amlogic-ng |
As discussed on PR #1129.
I'm not sure if this is what it should be (maybe use a newer kernel instead?) but at least it compiles for oga and gf.