Update retroarch fix audio amlogic old #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the retroarch update needed? |
|
No not needed. Code being patched is the same; although I only tested my patch on tag v1.16.0.3's commit. |
Yes, because you are actually downgrading it. |
Fix audio on Amlogic-old. On S905L at least!
bennydiamond
force-pushed
the
Update_retroarch_fix_audio_amlogic-old
branch
from
684734a
to
074f566
Compare
|
Oops... Fail. Rebased branch to remove faulty commit. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on my own build and found out there is no sound on recent version of RetroArch when building for Amlogic-old platform.
I made a patch file and confirmed it working on my S905L SOC. I don't have any other board to test this on tho...
I updated RetroArch commit id to tag v1.16.0.3 while at it!