Fixing numpy seed in flaky test #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #437 +/- ##
========================================
Coverage 89.04% 89.04%
========================================
Files 137 137
Lines 4820 4820
Branches 701 547 -154
========================================
Hits 4292 4292
Misses 403 403
Partials 125 125 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
apaleyes
reviewed
Dec 14, 2022
apaleyes
approved these changes
Dec 15, 2022
|
Thanks a lot for looking into this, Maren! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #421 , if available:
Description of changes:
This PR sets a fixed numpy.random.seed for the flaky test mentioned in the issue. It seems to stop the flakiness.
Still not entirely sure why it is flaky but it might be related to hyper-param optimization. In all the failed tests that I checked the lengthscale of the GP was very tiny for some reason (1e-300).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.