Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small bugfix in tests. #462

Merged
merged 3 commits into from
May 7, 2024
Merged

Conversation

mmahsereci
Copy link
Contributor

Issue #, if available:

Description of changes:

Some pytest fixtures in tests/emukit/quadrature/test_measures.py got changed to instances in #460 by accident. Changing them back to fixtures. Plus correcting a typo.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mmahsereci mmahsereci merged commit 2de6ef7 into EmuKit:main May 7, 2024
7 checks passed
@mmahsereci mmahsereci deleted the mm-bq-tests-fixtures branch May 7, 2024 13:50
@apaleyes
Copy link
Collaborator

apaleyes commented May 7, 2024

Thanks, Maren! It's great you are still able to contribute, nice!

Since it's two of us still, going forward let's stick to usual review cycle.

@mmahsereci
Copy link
Contributor Author

Thanks, Maren! It's great you are still able to contribute, nice!

Since it's two of us still, going forward let's stick to usual review cycle.

Well, in general I agree. This is a bug fix to PR #460 that also went in without review. Let's both be a bit a bit more careful I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants