-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coin Selection doesn't consider the minimum ADA for change #553
Comments
Hi @abdelkrimdev! It's a known issue, the current implementation of |
Yes, I already did that, but it's a hack, and it leads to some potential bugs in the future. I even built a mini coin selection here: |
@lisicky when are you guys planning to fix this issue? |
@AdamMachera fix requires small redesign inside tx builder. I would say fix will be in 11.5 release. I will try to make it faster |
Thanks @lisicky if I can help with anything let me know, I have a limited skillset in rust but for testing or anything |
@lisicky Regarding this workaround: What is the recommended way to remove an output from a TransactionBuilder? |
@tqueri has it been fixed in version 11.5? |
this error "Not enough ADA leftover to include non-ADA assets in a change address" happened to me when I used with_asset_and_min_required_coin which is DEPRECATED so I used with_asset_and_min_required_coin_by_utxo_cost instead. |
add_inputs_from
[LargestFirstMultiasset] doesn't consider the minimum ADA for change output, thus sometimes we don't have enough ADA in a tx's inputs to cover for minimum ADA in change output if we call add_inputs_from then call add_change_if_needed we getNot enough ADA leftover to include non-ADA assets in a change address
The text was updated successfully, but these errors were encountered: